qtubuntu-media

Merge lp://staging/~phablet-team/qtubuntu-media/fix-1528898 into lp://staging/qtubuntu-media

  1. fix-1528898
  2. Merge into trunk
Proposed by Jim Hodapp
Status: Merged
Approved by: Jim Hodapp
Approved revision: 100
Merged at revision: 95
Proposed branch: lp://staging/~phablet-team/qtubuntu-media/fix-1528898
Merge into: lp://staging/qtubuntu-media
Prerequisite: lp://staging/~phablet-team/qtubuntu-media/fix-removemedia
Diff against target: 180 lines (+68/-10)
6 files modified
debian/changelog (+7/-0)
src/aal/aalmediaplaylistcontrol.cpp (+27/-3)
src/aal/aalmediaplaylistcontrol.h (+1/-0)
src/aal/aalmediaplaylistprovider.cpp (+23/-7)
src/aal/aalmediaplaylistprovider.h (+3/-0)
src/aal/aalutility.cpp (+7/-0)
To merge this branch: bzr merge lp://staging/~phablet-team/qtubuntu-media/fix-1528898
Reviewer Review Type Date Requested Status
Andrew Hayzen (community) Approve
Alfonso Sanchez-Beato Pending
Review via email: mp+282328@code.staging.launchpad.net

This proposal supersedes a proposal from 2016-01-04.

Commit message

Fix bug #1528898

Description of the change

Fix bug #1528898

To post a comment you must log in.
Revision history for this message
Andrew Hayzen (ahayzen) wrote : Posted in a previous version of this proposal

LGTM :-)

review: Approve
Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote : Posted in a previous version of this proposal

See inline comment.

review: Needs Fixing
Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote : Posted in a previous version of this proposal

Looks good, but I have spotted a small formatting issue, see comment.

Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote : Posted in a previous version of this proposal

LGTM

review: Approve
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

LGTM :-)

review: Approve
Revision history for this message
Jim Hodapp (jhodapp) wrote :

Top approving myself since this is just to retarget for dual landing. There are no functional changes and abeato had previously top approved the superseded MR.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: