qtubuntu-media

Merge lp://staging/~phablet-team/qtubuntu-media/background-playlist-plugin-vivid into lp://staging/qtubuntu-media/stable

  1. background-playlist-plugin-vivid
  2. Merge into stable
Proposed by Jim Hodapp
Status: Merged
Approved by: Alfonso Sanchez-Beato
Approved revision: 110
Merged at revision: 84
Proposed branch: lp://staging/~phablet-team/qtubuntu-media/background-playlist-plugin-vivid
Merge into: lp://staging/qtubuntu-media/stable
Diff against target: 3322 lines (+2576/-174)
30 files modified
aalMediaPlayer.pro (+1/-1)
debian/changelog (+11/-5)
debian/control (+6/-1)
src/aal/aal.pro (+8/-4)
src/aal/aalmediaplayercontrol.cpp (+16/-66)
src/aal/aalmediaplayercontrol.h (+0/-2)
src/aal/aalmediaplayerservice.cpp (+234/-73)
src/aal/aalmediaplayerservice.h (+16/-4)
src/aal/aalmediaplayerserviceplugin.cpp (+0/-1)
src/aal/aalmediaplaylistcontrol.cpp (+293/-0)
src/aal/aalmediaplaylistcontrol.h (+82/-0)
src/aal/aalmediaplaylistprovider.cpp (+346/-0)
src/aal/aalmediaplaylistprovider.h (+83/-0)
src/aal/aalutility.cpp (+39/-0)
src/aal/aalutility.h (+35/-0)
src/aal/private/qmediaplaylistnavigator_p.h (+112/-0)
src/aal/private/qmediaplaylistprovider_p.h (+115/-0)
src/aal/qmediaplaylistcontrol_p.h (+96/-0)
tests/integration/integration.pro (+23/-0)
tests/integration/tst_mediaplaylist.cpp (+396/-0)
tests/integration/tst_mediaplaylist.h (+75/-0)
tests/tests.pro (+9/-0)
tests/unit/player.cpp (+6/-0)
tests/unit/player.h (+1/-0)
tests/unit/player_mock.cpp (+313/-0)
tests/unit/player_mock.h (+104/-0)
tests/unit/tst_mediaplayerplugin.cpp (+10/-2)
tests/unit/tst_mediaplaylistcontrol.cpp (+66/-0)
tests/unit/tst_mediaplaylistcontrol.h (+59/-0)
tests/unit/unit.pro (+21/-15)
To merge this branch: bzr merge lp://staging/~phablet-team/qtubuntu-media/background-playlist-plugin-vivid
Reviewer Review Type Date Requested Status
Alfonso Sanchez-Beato Approve
Ubuntu Phablet Team Pending
Review via email: mp+266761@code.staging.launchpad.net

Commit message

Added background playlist support connecting qtmultimedia with media-hub.

Description of the change

Added background playlist support connecting qtmultimedia with media-hub.

To post a comment you must log in.
Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote :

Look good, although I have some minor comments.

review: Needs Fixing
lp://staging/~phablet-team/qtubuntu-media/background-playlist-plugin-vivid updated
110. By Jim Hodapp

Address code review comments

Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote :

LGTM

review: Approve
lp://staging/~phablet-team/qtubuntu-media/background-playlist-plugin-vivid updated
111. By Jim Hodapp

Make sure is initialized to nullptr when the service instance is created

112. By Jim Hodapp

Delete unnecessary debug statements that snuck in to the last commit

113. By Jim Hodapp

Fix compile issue

114. By Jim Hodapp

Some minor fixes for when a client instance goes out of scope

115. By Jim Hodapp

Disconnect and reconnect the end_of_stream signal with attach/dettach of Player session. Also re-emit the status to the client app.

116. By Jim Hodapp

Disable media-hub player session attach/detach for now since it currently is not needed and causes signals to no longer function after reattach

117. By Jim Hodapp

Cleanup of all controls and services more robustly

118. By Jim Hodapp

Merge with Simon's branch to fix EOS signal issue

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: