Merge lp://staging/~phablet-team/qtubuntu-camera/fix-trust-prompt-bugs into lp://staging/qtubuntu-camera/stable
Proposed by
Jim Hodapp
| Status: | Merged |
|---|---|
| Approved by: | Jim Hodapp |
| Approved revision: | 153 |
| Merged at revision: | 149 |
| Proposed branch: | lp://staging/~phablet-team/qtubuntu-camera/fix-trust-prompt-bugs |
| Merge into: | lp://staging/qtubuntu-camera/stable |
| Diff against target: |
595 lines (+152/-136) 7 files modified
debian/changelog (+3/-3) debian/control (+1/-1) src/aalmediarecordercontrol.cpp (+115/-86) src/aalmediarecordercontrol.h (+9/-5) src/audiocapture.cpp (+13/-26) src/audiocapture.h (+6/-10) unittests/stubs/audiocapture_stub.cpp (+5/-5) |
| To merge this branch: | bzr merge lp://staging/~phablet-team/qtubuntu-camera/fix-trust-prompt-bugs |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Jim Hodapp (community) | code | Approve | |
|
Review via email:
|
|||
Commit message
Refactor media recorder code to:
- ensure proper cleanups
- prevent double start/stop of recordings
- allow for soundless recordings
- do not start recording before microphone access is allowed/forbidden by user
Description of the change
Refactor media recorder code to:
- ensure proper cleanups
- prevent double start/stop of recordings
- allow for soundless recordings
- do not start recording before microphone access is allowed/forbidden by user
Fixes:
Bug #1487126: Camera/mic trust: initial video corrupt
Bug #1487131: Camera/mic trust: mic denial in camera-app freezes camera
Bug #1487159: revoking mic permission in system-settings, camera appears to record but video is unplayable
To post a comment you must log in.
Revision history for this message
| Florian Boucault (fboucault) | # |
Revision history for this message
| Jim Hodapp (jhodapp) | # |
review:
Approve
(code)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
A few comments/questions inline.