Merge lp://staging/~phablet-team/qtubuntu-camera/fix-trust-prompt-bugs into lp://staging/qtubuntu-camera

Proposed by Jim Hodapp
Status: Superseded
Proposed branch: lp://staging/~phablet-team/qtubuntu-camera/fix-trust-prompt-bugs
Merge into: lp://staging/qtubuntu-camera
Diff against target: 533 lines (+135/-126)
5 files modified
src/aalmediarecordercontrol.cpp (+103/-89)
src/aalmediarecordercontrol.h (+9/-5)
src/audiocapture.cpp (+14/-20)
src/audiocapture.h (+3/-7)
unittests/stubs/audiocapture_stub.cpp (+6/-5)
To merge this branch: bzr merge lp://staging/~phablet-team/qtubuntu-camera/fix-trust-prompt-bugs
Reviewer Review Type Date Requested Status
Ubuntu Phablet Team Pending
Review via email: mp+268774@code.staging.launchpad.net
To post a comment you must log in.
149. By Florian Boucault

Refactor media recorder code to:
- ensure proper cleanups
- prevent double start/stop of recordings
- allow for soundless recordings
- do not start recording before microphone access is allowed/forbidden by user

150. By Florian Boucault

Slightly clearer if/else

151. By Jim Hodapp

Fix package version and libqtubuntu-media-signals-dev dependency version.

152. By Florian Boucault

Small status fix

153. By Florian Boucault

Reset m_audioCaptureAvailable in cleanup.

154. By Florian Boucault

In the case of a timeout error signalled by pulseaudio when trying to use the microphone, be smart and prevent any further recording.

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: