ofono

Merge lp://staging/~phablet-team/ofono/ww10-update into lp://staging/~phablet-team/ofono/ubuntu

ww10-update
Merge into ubuntu

Proposed by Tony Espy on 2015-02-23

Status:

Merged

Approved by:

Alfonso Sanchez-Beato on 2015-02-24

Approved revision:

6888

Merged at revision:

6888

Proposed branch:

lp://staging/~phablet-team/ofono/ww10-update

Merge into:

lp://staging/~phablet-team/ofono/ubuntu

Diff against target:

392 lines (+159/-59)

8 files modified

debian/changelog (+15/-0)
drivers/mtkmodem/voicecall.c (+2/-6)
gril/grilreply.c (+50/-12)
gril/grilrequest.c (+0/-9)
gril/grilutil.c (+20/-0)
gril/ril_constants.h (+12/-0)
plugins/mtk.c (+35/-7)
unit/test-grilrequest.c (+25/-25)

To merge this branch:

bzr merge lp://staging/~phablet-team/ofono/ww10-update

Related bugs:

Bug #1419675: [krillin] Second slot not detected on reboot	High	Fix Released
Bug #1422401: dialer app doesn't work correctly on multiple calls on a wired headset	Undecided	Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Alfonso Sanchez-Beato		2015-02-23	Approve on 2015-02-24
PS Jenkins bot	continuous-integration		Approve on 2015-02-23
Review via email: mp+250665@code.staging.launchpad.net

Commit message

[ Alfonso Sanchez-Beato ]
  * mtkmodem/voicecall.c: fix fast call answer (LP: #1422401)
    Fix problem that occurs when calls are answer too quickly.
  * mtk.c: wait for radio event before onlining (LP: #1419675)
    Ensure that the 2nd SIM slot on krillin is always
    initialized properly.
  * gril/grilrequest.c, unit: support empty APN
    Allow data calls with GPRS contexts that have empty APNs.
  * grilreply.c, grilutil.c, ril_constants.c: fix arale parcel parsing
    Fix parcel parsing issues with radio tech and SIM PIN retries.

Description of the change

This branch includes four bug fixes:

1. Fix a problem that occurs when calls are answered too quickly (LP: #1422401)

2. Fix parsing problems on arale with SIM PIN retries and radio technologies

3. Fix an issue where the 2nd slot on krillin isn't always recognized (LP: #1419675; REGRESSION)

4. Allow data calls to be established with GPRS contexts that have no APN specified.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-02-23:

PASSED: Continuous integration, rev:6888
http://jenkins.qa.ubuntu.com/job/phablet-team-ofono-ubuntu-ci/66/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-team-ofono-ubuntu-vivid-amd64-ci/4
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-team-ofono-ubuntu-vivid-armhf-ci/4
        deb: http://jenkins.qa.ubuntu.com/job/phablet-team-ofono-ubuntu-vivid-armhf-ci/4/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-team-ofono-ubuntu-vivid-i386-ci/4

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/phablet-team-ofono-ubuntu-ci/66/rebuild

review: Approve (continuous-integration)

Revision history for this message

Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote on 2015-02-24:

Looks good to me

review: Approve

Revision history for this message

Tony Espy (awe) wrote on 2015-02-26:

Test Results:

1. mako - #111

Tested 'Empty APN' change. Prior to this change, ofono would not send a RIL_REQUEST_SETUP_DATA_CALL for a gprs context with an empty ( ie. "" ) access point name. As none of the operators in the US support this, all I could confirm is that the request is sent.

2. krillin - #122

- tested fast answer of incoming calls
- rebooted 12 times to ensure that 2nd SIM is properly recognized
NOTE - 2 out of 12 attempts, after unlocking the 2nd SIM and then unlocking the phone,
the 2nd SIM needed to be unlocked a 2nd time. It seems there's a race condition present.
- verified that radio technology is parsed correctly ( unfortunately it's only ever edge in the US )
- verified that SIM retries count is properly parsed

3. arale - #103

- tested fast answer of incoming calls (6 times)
- rebooted to ensure modem is properly recognized (6 times)
- verified that radio technology is correct for 2G (edge) and 3G+ (HSPA)
- verified that SIM PIN retries are parsed correctly

Revision history for this message

Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote on 2015-02-26:

Test results:

1. arale, vivid-proposed #110

  - SIM PIN retries parsing tested
  - No <INVALID> techs shown in log when ofono is run with debugging on
  - Tested fast answer
  - Sanity testing of outgoing calls and mobile data

2. krillin, 14.09-proposed #245

  - SIM PIN retries parsing tested
  - Tested fast answer
  - Sanity testing of outgoing calls and mobile data
  - Tested empty APN with movistar Spain operator, editing the <IMSI>/gprs file
Verified that the second slot is always recognized (10 reboots). I have not seen the issue with the PIN Tony mentions, although I activated the PIN for the second SIM. The setup was 2 SIMs inserted, and only the second one with PIN. In latest RTM release (#18) a bug appeared due to changes to libqofono: the welcome wizard did not ask for a SIM to be inserted and then reboot (libqofono had changed its behaviour to asynchronous). I wonder if it is the same issue. The unity changes to solve this already landed in RTM, for vivid I have seen they have just landed (line 40 in the spreadsheet), but maybe they are not yet in an image. It might be worth to wait for them and test again.