Merge lp://staging/~phablet-team/network-manager/ofono-format-cleanup into lp://staging/~network-manager/network-manager/ubuntu

Proposed by Tony Espy
Status: Merged
Approved by: Ricardo Salveti
Approved revision: 959
Merged at revision: 957
Proposed branch: lp://staging/~phablet-team/network-manager/ofono-format-cleanup
Merge into: lp://staging/~network-manager/network-manager/ubuntu
Prerequisite: lp://staging/~phablet-team/network-manager/ofono-rm-unused-code
Diff against target: 233 lines (+52/-56)
1 file modified
debian/patches/0001-wwan-add-support-for-using-oFono-as-a-modem-manager.patch (+52/-56)
To merge this branch: bzr merge lp://staging/~phablet-team/network-manager/ofono-format-cleanup
Reviewer Review Type Date Requested Status
Mathieu Trudel-Lapierre Abstain
Ricardo Salveti (community) Approve
Review via email:

Description of the change

Cleanup code format and fix indentation ( ie. usage of tabs vs. spaces ).

To post a comment you must log in.
958. By Tony Espy

Remove unused nm-modem-ofono.c function: do_context_prepare()

959. By Tony Espy

Cleanup nm-modem-ofono.c formating and tabs/spaces.

Revision history for this message
Ricardo Salveti (rsalveti) wrote :

+1, no functional changes but it makes it easier to maintain and change the patch set as we go.

review: Approve
Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

Changeset is fine, but given that the code style isn't being in the way, I'd rather avoid making cosmetic changes two weeks away from Vivid release, even when bundled with bugfixes. I don't see why it couldn't wait two more weeks and land in the next release cycle.

Call me extra careful, but it's *very* late in the release so I'd defer the decision of landing this despite it being cosmetic changes to the release team. Could you please bring it up to them?

review: Abstain
Revision history for this message
Ricardo Salveti (rsalveti) wrote :

The thing about not waiting for two more extra weeks (for next release) is because we're still going to maintain this code base (vivid based) for RTM for a few months.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.


People subscribed via source and target branches