NetworkManager

Merge lp://staging/~phablet-team/network-manager/ofono-format-cleanup into lp://staging/~network-manager/network-manager/ubuntu

ofono-format-cleanup
Merge into ubuntu

Proposed by Tony Espy on 2015-04-06

Status:	Merged
Approved by:	Ricardo Salveti on 2015-04-09
Approved revision:	959
Merged at revision:	957
Proposed branch:	lp://staging/~phablet-team/network-manager/ofono-format-cleanup
Merge into:	lp://staging/~network-manager/network-manager/ubuntu
Prerequisite:	lp://staging/~phablet-team/network-manager/ofono-rm-unused-code
Diff against target:	233 lines (+52/-56) 1 file modified debian/patches/0001-wwan-add-support-for-using-oFono-as-a-modem-manager.patch (+52/-56)
To merge this branch:	bzr merge lp://staging/~phablet-team/network-manager/ofono-format-cleanup
Related bugs:	Link a bug report

Reviewer	Date Requested	Status
Mathieu Trudel-Lapierre		Abstain on 2015-04-07
Ricardo Salveti (community)	2015-04-06	Approve on 2015-04-07
Review via email: mp+255306@code.staging.launchpad.net

Description of the change

Cleanup code format and fix indentation ( ie. usage of tabs vs. spaces ).

lp://staging/~phablet-team/network-manager/ofono-format-cleanup updated on 2015-04-06

958. By Tony Espy on 2015-04-06: Remove unused nm-modem-ofono.c function: do_context_prepare()
959. By Tony Espy on 2015-04-06: Cleanup nm-modem-ofono.c formating and tabs/spaces.

Revision history for this message

Ricardo Salveti (rsalveti) wrote on 2015-04-07:

+1, no functional changes but it makes it easier to maintain and change the patch set as we go.

review: Approve

Revision history for this message

Mathieu Trudel-Lapierre (cyphermox) wrote on 2015-04-07:

Changeset is fine, but given that the code style isn't being in the way, I'd rather avoid making cosmetic changes two weeks away from Vivid release, even when bundled with bugfixes. I don't see why it couldn't wait two more weeks and land in the next release cycle.

Call me extra careful, but it's *very* late in the release so I'd defer the decision of landing this despite it being cosmetic changes to the release team. Could you please bring it up to them?

review: Abstain

Revision history for this message

Ricardo Salveti (rsalveti) wrote on 2015-04-07:

The thing about not waiting for two more extra weeks (for next release) is because we're still going to maintain this code base (vivid based) for RTM for a few months.