Merge lp://staging/~phablet-team/network-manager/lp1480877-wifi-rm-dup-scan-signals-vivid into lp://staging/~phablet-team/network-manager/vivid-phone-overlay

Proposed by Tony Espy
Status: Merged
Approved by: Alfonso Sanchez-Beato
Approved revision: 969
Merged at revision: 969
Proposed branch: lp://staging/~phablet-team/network-manager/lp1480877-wifi-rm-dup-scan-signals-vivid
Merge into: lp://staging/~phablet-team/network-manager/vivid-phone-overlay
Diff against target: 192 lines (+115/-30)
2 files modified
debian/changelog (+8/-0)
debian/patches/0002-wifi-cull-the-scan-list-before-signalling-ScanDone-b.patch (+107/-30)
To merge this branch: bzr merge lp://staging/~phablet-team/network-manager/lp1480877-wifi-rm-dup-scan-signals-vivid
Reviewer Review Type Date Requested Status
Mathieu Trudel-Lapierre Approve
Simon Fels Pending
Review via email:

Description of the change

This change fixes a problem where duplicate (2-3x) AccessPoint 'LastSeen' PropertiesChanged signals are generated each time a WiFi scan completes. This can be seen by running:

dbus-monitor --system --profile "type='signal',sender='org.freedesktop.NetworkManager'"

...and waiting for a scan to occur. You'll see 2-3 PropsChanged for each AccessPoint after a scan. From then on, you'll only see changes for AccessPoint/0 until the next scan happens.

The change makes cull_scan_list the function responsible for updating an AP's last-seen property, and ensures that scan_done_cb is the only function that calls cull_scan_list. It also removes the bss_updated_cb function, as its only purpose was to update the last-seen property and schedule yet another scanlist cull.

To post a comment you must log in.
969. By Tony Espy

Fix duplicate 'LastSeen' PropertiesChanged signals being emitted
after scanning (LP: #1480877).

Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.


People subscribed via source and target branches

to all changes: