Merge lp://staging/~phablet-team/network-manager/lp1444162 into lp://staging/~phablet-team/network-manager/vivid-phone-overlay

Proposed by Tony Espy
Status: Merged
Approved by: Mathieu Trudel-Lapierre
Approved revision: 970
Merged at revision: 968
Proposed branch: lp://staging/~phablet-team/network-manager/lp1444162
Merge into: lp://staging/~phablet-team/network-manager/vivid-phone-overlay
Prerequisite: lp://staging/~phablet-team/network-manager/lp1425172
Diff against target: 73 lines (+48/-1)
3 files modified
debian/changelog (+3/-1)
debian/patches/lp1444162-add-ip6-config-to-nm-ofono-connections.patch (+44/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp://staging/~phablet-team/network-manager/lp1444162
Reviewer Review Type Date Requested Status
Mathieu Trudel-Lapierre Approve
Review via email: mp+267967@code.staging.launchpad.net

Description of the change

This change fixes NM's ofono setting plugin to add IP6_CONFIG_METHOD_IGNORE setting to ofono connections so that NM doesn't configure IPv6 for ofono connections.

To post a comment you must log in.
Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

There's a Bug: tag that exists in DEP-3; but it's really meant for upstream bugs. I suggest you replace that with Bug-Ubuntu: and move it up with the other Author: Subject:, etc for next patches.

review: Approve
Revision history for this message
Tony Espy (awe) wrote :

Tested on krillin / rc-proposed / #97.

Ran all of Basic Tests from:

https://wiki.ubuntu.com/Process/Merges/TestPlans/network-manager

No problems found.

Revision history for this message
Tony Espy (awe) wrote :

Tested on mako / rc-proposed / #217.

Ran all** of the Basic Tests from:

https://wiki.ubuntu.com/Process/Merges/TestPlans/network-manager

No problems found.

** Didn't run the force-disconnect test case.

Also, note that while testing krillin, the set-radio-tech test case wasn't run either due to only EDGE/GSM being supported in the US.

Revision history for this message
Tony Espy (awe) wrote :

Tested on arale / rc-proposed / #88.

Ran all of the Basic Tests from:

https://wiki.ubuntu.com/Process/Merges/TestPlans/network-manager

No problems found.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: