Merge lp://staging/~phablet-team/network-manager/lp1425172 into lp://staging/~phablet-team/network-manager/vivid-phone-overlay
Proposed by
Tony Espy
| Status: | Merged |
|---|---|
| Approved by: | Mathieu Trudel-Lapierre |
| Approved revision: | 968 |
| Merged at revision: | 967 |
| Proposed branch: | lp://staging/~phablet-team/network-manager/lp1425172 |
| Merge into: | lp://staging/~phablet-team/network-manager/vivid-phone-overlay |
| Prerequisite: | lp://staging/~phablet-team/network-manager/lp1445134-wifi-scan-fix-vivid |
| Diff against target: |
60 lines (+35/-1) 3 files modified
debian/changelog (+4/-1) debian/patches/lp1425172-fix-wifi-scanlist-cull.patch (+30/-0) debian/patches/series (+1/-0) |
| To merge this branch: | bzr merge lp://staging/~phablet-team/network-manager/lp1425172 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Mathieu Trudel-Lapierre | Approve | ||
|
Review via email:
|
|||
Description of the change
This change fixes a bug in NetworkManager which caused access points to remain in the scan list for 6m or more when they'd actually gone offline. This was due to a hard-coded timer in NM. This change makes NM remove access points when notified by wpa_supplicant that they're now gone.
To post a comment you must log in.
Revision history for this message
| Tony Espy (awe) wrote | # |
Revision history for this message
| Mathieu Trudel-Lapierre (cyphermox) | # |
review:
Approve
Revision history for this message
| Tony Espy (awe) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Logic looks fine, but this patch is missing the appropriate DEP-3 patch tags. Could you please fix that?
Is it a patch cherry-picked from upstream or did you make the code changes yourself? This should be reflected in the patch tags. If it's a cherry-pick, the ideal is to use the patch as-is, as the git patch from format-patch will already contain all the necessary information.