Merge lp://staging/~phablet-team/network-manager/lp1425172-wily into lp://staging/~network-manager/network-manager/ubuntu

Proposed by Tony Espy
Status: Merged
Approved by: Mathieu Trudel-Lapierre
Approved revision: 974
Merged at revision: 974
Proposed branch: lp://staging/~phablet-team/network-manager/lp1425172-wily
Merge into: lp://staging/~network-manager/network-manager/ubuntu
Diff against target: 60 lines (+40/-0)
3 files modified
debian/changelog (+9/-0)
debian/patches/lp1425172-fix-wifi-scanlist-cull.patch (+30/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp://staging/~phablet-team/network-manager/lp1425172-wily
Reviewer Review Type Date Requested Status
Mathieu Trudel-Lapierre Approve
Review via email:

Description of the change

This change fixes a bug in NetworkManager which caused access points to remain in the scan list for 6m or more when they'd actually gone offline. This was due to a hard-coded timer in NM. This change makes NM remove access points when notified by wpa_supplicant that they're now gone.

To post a comment you must log in.
Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

Logic looks fine, but this patch is missing the appropriate DEP-3 patch tags. Could you please fix that?

Is it a patch cherry-picked from upstream or did you make the code changes yourself? This should be reflected in the patch tags. If it's a cherry-pick, the ideal is to use the patch as-is, as the git patch from format-patch will already contain all the necessary information.

review: Needs Fixing
974. By Tony Espy

d/p/lp1425172-fix-wifi-scanlist-cull.patch: add DEP-3 tags

Revision history for this message
Tony Espy (awe) wrote :

This is my own patch. I discussed this with dcbw on Friday, and he vetted the approach. He'd made similar changes in an un-landed branch in the upstream git tree, but as his changes are much more extensive, I opted for a simpler approach to fix this bug.

DEP-3 tags added to the patch.

Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

Looks fine, please see about requesting the silo to land this.

review: Approve
Revision history for this message
Tony Espy (awe) wrote :

Tested on krillin / devel-proposed / #165.

Ran the Basic Tests from:

Also added a new test case for aging access points and verified that it works on krillin.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.


People subscribed via source and target branches