NetworkManager

Merge lp://staging/~phablet-team/network-manager/lp1361864-wily into lp://staging/~network-manager/network-manager/ubuntu

  1. lp1361864-wily
  2. Merge into ubuntu
Proposed by Tony Espy
Status: Merged
Approved by: Mathieu Trudel-Lapierre
Approved revision: 970
Merged at revision: 970
Proposed branch: lp://staging/~phablet-team/network-manager/lp1361864-wily
Merge into: lp://staging/~network-manager/network-manager/ubuntu
Diff against target: 686 lines (+251/-166)
3 files modified
debian/changelog (+3/-0)
debian/patches/0001-wwan-add-support-for-using-oFono-as-a-modem-manager.patch (+18/-63)
debian/patches/add_ofono_settings_support.patch (+230/-103)
To merge this branch: bzr merge lp://staging/~phablet-team/network-manager/lp1361864-wily
Reviewer Review Type Date Requested Status
Mathieu Trudel-Lapierre Approve
Review via email: mp+265327@code.staging.launchpad.net

Description of the change

This change adds support for ofono's new gprs-context 'Preferred' property.

See touch test plan for test cases:

https://wiki.ubuntu.com/Process/Merges/TestPlans/network-manager

To post a comment you must log in.
Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

Looking briefly, things look sane. Packaging itself is fine too. I guess you've already had other code review on these changes?

review: Needs Information
Revision history for this message
Tony Espy (awe) wrote :

> Looking briefly, things look sane. Packaging itself is fine too. I guess
> you've already had other code review on these changes?

Yes, it was reviewed and tested in-depth across all three devices by engineering & QA before landing in the overlay PPA.

Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches