Merge lp://staging/~phablet-team/messaging-framework/telepathy-metadata-interface into lp://staging/messaging-framework
Proposed by
Roberto Mier Escandon
Status: | Needs review |
---|---|
Proposed branch: | lp://staging/~phablet-team/messaging-framework/telepathy-metadata-interface |
Merge into: | lp://staging/messaging-framework |
Diff against target: |
345 lines (+258/-3) 7 files modified
include/messaging/qt/tp/interfaces/base_channel_destroyable_internal.h (+1/-1) include/messaging/qt/tp/interfaces/base_channel_file_transfer_metadata.h (+76/-0) include/messaging/qt/tp/interfaces/base_channel_file_transfer_metadata_internal.h (+54/-0) include/messaging/qt/tp/interfaces/base_channel_roles_internal.h (+2/-1) include/messaging/qt/tp/interfaces/types.h (+4/-1) src/CMakeLists.txt (+3/-0) src/messaging/qt/tp/interfaces/base_channel_file_transfer_metadata.cpp (+118/-0) |
To merge this branch: | bzr merge lp://staging/~phablet-team/messaging-framework/telepathy-metadata-interface |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
system-apps-ci-bot | continuous-integration | Approve | |
Ubuntu Phablet Team | Pending | ||
Review via email: mp+303473@code.staging.launchpad.net |
Commit message
Implementation of interface described here https:/
This interface is needed to hold file transfer identifier while channel is active
Modified some bad modificators in the other interfaces
Description of the change
Implementation of interface described here https:/
Modified some bad modificators in the other interfaces
To post a comment you must log in.
Unmerged revisions
- 57. By Roberto Mier Escandon
-
merged trunk
- 56. By Roberto Mier Escandon
-
finished implementation
- 55. By Roberto Mier Escandon
-
first code
PASSED: Continuous integration, rev:56 /jenkins. canonical. com/system- apps/job/ lp-messaging- framework- ci/41/ /jenkins. canonical. com/system- apps/job/ build/1261 /jenkins. canonical. com/system- apps/job/ test-0- autopkgtest/ label=phone- armhf,release= vivid+overlay, testname= default/ 274 /jenkins. canonical. com/system- apps/job/ build-0- fetch/1261 /jenkins. canonical. com/system- apps/job/ build-1- sourcepkg/ release= vivid+overlay/ 1130 /jenkins. canonical. com/system- apps/job/ build-1- sourcepkg/ release= xenial+ overlay/ 1130 /jenkins. canonical. com/system- apps/job/ build-1- sourcepkg/ release= yakkety/ 1130 /jenkins. canonical. com/system- apps/job/ build-2- binpkg/ arch=amd64, release= vivid+overlay/ 1117 /jenkins. canonical. com/system- apps/job/ build-2- binpkg/ arch=amd64, release= vivid+overlay/ 1117/artifact/ output/ *zip*/output. zip /jenkins. canonical. com/system- apps/job/ build-2- binpkg/ arch=amd64, release= xenial+ overlay/ 1117 /jenkins. canonical. com/system- apps/job/ build-2- binpkg/ arch=amd64, release= xenial+ overlay/ 1117/artifact/ output/ *zip*/output. zip /jenkins. canonical. com/system- apps/job/ build-2- binpkg/ arch=amd64, release= yakkety/ 1117 /jenkins. canonical. com/system- apps/job/ build-2- binpkg/ arch=amd64, release= yakkety/ 1117/artifact/ output/ *zip*/output. zip /jenkins. canonical. com/system- apps/job/ build-2- binpkg/ arch=armhf, release= vivid+overlay/ 1117 /jenkins. canonical. com/system- apps/job/ build-2- binpkg/ arch=armhf, release= vivid+overlay/ 1117/artifact/ output/ *zip*/output. zip /jenkins. canonical. com/system- apps/job/ build-2- binpkg/ arch=armhf, release= xenial+ overlay/ 1117 /jenkins. canonical. com/system- apps/job/ build-2- binpkg/ arch=armhf, release= xenial+ overlay/ 1117/artifact/ output/ *zip*/output. zip /jenkins. canonical. com/system- apps/job/ build-2- binpkg/ arch=armhf, release= yakkety/ 1117 /jenkins. canonical. com/system- apps/job/ build-2- binpkg/ arch=armhf, release= yakkety/ 1117/artifact/ output/ *zip*/output. zip /jenkins. canonical. com/system- apps/job/ build-2- binpkg/ arch=i386, release= vivid+overlay/ 1117 /jenkins. canonical. com/system- apps/job/ build-2- binpkg/ arch=i386, release= vivid+overlay/ 1117/artifact/ output/ *zip*/output. zip /jenkins. canonical. com/system- apps/job/ build-2- binpkg/ arch=i386, release= xenial+ overlay/ 1117 /jenkins. canonical. com/system- apps/job/ build-2- binpkg/ arch=i386, release= xenial+ overlay/ 1117/artifact/ output/ *zip*/output. zip /jenkins. canonical. com/system- apps/job/ build-2- binpkg/ arch=i386, release= yakkety/ 1117 /jenkins. canonical. com/system- apps/job/ build-2- binpkg/ arch=i386, release= yakkety/ 1117/artifact/ output/ *zip*/output. zip
https:/
Executed test runs:
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
Click here to trigger a rebuild: /jenkins. canonical. com/system- apps/job/ lp-messaging- framework- ci/41/rebuild
https:/