messaging-framework

Merge lp://staging/~phablet-team/messaging-framework/dynamic-soname into lp://staging/messaging-framework

  1. dynamic-soname
  2. Merge into trunk
Proposed by Roberto Mier Escandon
Status: Merged
Approved by: Roberto Mier Escandon
Approved revision: 84
Merged at revision: 72
Proposed branch: lp://staging/~phablet-team/messaging-framework/dynamic-soname
Merge into: lp://staging/messaging-framework
Prerequisite: lp://staging/~ken-vandine/messaging-framework/packaging_cleanup
Diff against target: 599 lines (+250/-107)
21 files modified
CMakeLists.txt (+15/-6)
HACKING.md (+77/-0)
README.md (+0/-15)
data/CMakeLists.txt (+4/-4)
data/messaging-framework.pc.in (+10/-0)
data/messaging-fw.pc.in (+0/-10)
debian/bileto_pre_release_hook (+22/-0)
debian/control (+0/-50)
debian/control.in (+49/-0)
debian/libmessaging-framework-dev.install (+3/-0)
debian/libmessaging-framework1.install.in (+2/-0)
debian/libmessaging-framework1.shlibs.in (+1/-0)
debian/libmessaging-fw-dev.install (+0/-3)
debian/libmessaging-fw1.install (+0/-2)
debian/rules (+4/-3)
include/CMakeLists.txt (+1/-1)
src/CMakeLists.txt (+12/-11)
tests/CMakeLists.txt (+1/-1)
tests/unit/messaging/CMakeLists.txt (+1/-1)
tools/CMakeLists.txt (+4/-0)
tools/get_soversion.sh (+44/-0)
To merge this branch: bzr merge lp://staging/~phablet-team/messaging-framework/dynamic-soname
Reviewer Review Type Date Requested Status
system-apps-ci-bot continuous-integration Approve
Gustavo Pichorim Boiko (community) Approve
Review via email: mp+310557@code.staging.launchpad.net

Commit message

Have dynamic soversion for the fw depending on the distro, to avoid ABI break problems with gcc or libboost different versions. (see https://wiki.ubuntu.com/Bileto?action=show&redirect=citrain%2FLandingProcess#Handling_Symbols)
Using messaging-framework word instead of messaging-fw in all the project

Description of the change

Have dynamic soversion for the fw depending on the distro, to avoid ABI break problems with gcc or libboost different versions. (see https://wiki.ubuntu.com/Bileto?action=show&redirect=citrain%2FLandingProcess#Handling_Symbols)
Using messaging-framework word instead of messaging-fw in all the project

To post a comment you must log in.
Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :

FAILED: Continuous integration, rev:77
https://jenkins.canonical.com/system-apps/job/lp-messaging-framework-ci/94/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-apps/job/build/1961/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-0-fetch/1962/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-messaging-framework-ci/94/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :

FAILED: Continuous integration, rev:79
https://jenkins.canonical.com/system-apps/job/lp-messaging-framework-ci/95/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-apps/job/build/1966/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-0-fetch/1967/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-messaging-framework-ci/95/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :

FAILED: Continuous integration, rev:80
https://jenkins.canonical.com/system-apps/job/lp-messaging-framework-ci/96/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-apps/job/build/1968/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-0-fetch/1969/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-messaging-framework-ci/96/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :

FAILED: Continuous integration, rev:81
https://jenkins.canonical.com/system-apps/job/lp-messaging-framework-ci/97/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-apps/job/build/1969/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-0-fetch/1970/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-messaging-framework-ci/97/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote :

We probably need to get the CI jobs to run a step to generate debian/control before building the package, but other than that the code looks good!

review: Approve
Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
https://jenkins.canonical.com/system-apps/job/lp-messaging-framework-autoland/42/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-apps/job/build/1972/console
    None: https://jenkins.canonical.com/system-apps/job/lp-generic-land-mp/59/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-0-fetch/1973/console

review: Needs Fixing (continuous-integration)
Revision history for this message
James Henstridge (jamesh) wrote :

Gary Wang mentioned this merge proposal to me, since you borrowed some of the multi-landing bits I wrote for storage-framework.

Just a small note:

For the libstorage-framework-provider library, we exposed boost types in our public API. This is why our ABI breaks with each new Boost version (since they don't maintain ABI stability).

If that's not the case for your library, you probably only need one soname for gcc 4.9 (vivid), and another for gcc >= 5.

If you're unsure, one option would be to build the library with debug symbols on xenial and zesty, and then compare the results using the abidiff tool (found in the abigail-tools package).

Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :

FAILED: Continuous integration, rev:82
https://jenkins.canonical.com/system-apps/job/lp-messaging-framework-ci/98/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-apps/job/build/1987/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-0-fetch/1990/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-messaging-framework-ci/98/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :

FAILED: Continuous integration, rev:83
https://jenkins.canonical.com/system-apps/job/lp-messaging-framework-ci/99/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-apps/job/build/2007/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/2010
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1840/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1840
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1840/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=zesty/1840
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=zesty/1840/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1840/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1840
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1840/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=zesty/1840
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=zesty/1840/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/1840/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/1840
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/1840/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=zesty/1840
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=zesty/1840/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-messaging-framework-ci/99/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
https://jenkins.canonical.com/system-apps/job/lp-messaging-framework-autoland/43/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-apps/job/build/2010/console
    None: https://jenkins.canonical.com/system-apps/job/lp-generic-land-mp/60/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/2013
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1843/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1843
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1843/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=zesty/1843
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=zesty/1843/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1843/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1843
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1843/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=zesty/1843
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=zesty/1843/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/1843/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/1843
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/1843/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=zesty/1843
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=zesty/1843/artifact/output/*zip*/output.zip

review: Needs Fixing (continuous-integration)
lp://staging/~phablet-team/messaging-framework/dynamic-soname updated
84. By Roberto Mier Escandon

corrected minimum version for libboost be 1.55

Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :

PASSED: Continuous integration, rev:84
https://jenkins.canonical.com/system-apps/job/lp-messaging-framework-ci/100/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build/2011
    SUCCESS: https://jenkins.canonical.com/system-apps/job/test-0-autopkgtest/label=phone-armhf,release=vivid+overlay,testname=default/487
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/2014
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1844
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1844/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1844
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1844/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=zesty/1844
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=zesty/1844/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1844
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1844/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1844
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1844/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=zesty/1844
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=zesty/1844/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/1844
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/1844/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/1844
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/1844/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=zesty/1844
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=zesty/1844/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-messaging-framework-ci/100/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: