messaging-app

Merge lp://staging/~phablet-team/messaging-app/load-components-on-demand into lp://staging/messaging-app

  1. load-components-on-demand
  2. Merge into trunk
Proposed by Tiago Salem Herrmann
Status: Merged
Approved by: Arthur Mello
Approved revision: 486
Merged at revision: 501
Proposed branch: lp://staging/~phablet-team/messaging-app/load-components-on-demand
Merge into: lp://staging/messaging-app
Prerequisite: lp://staging/~phablet-team/messaging-app/enable_other_attachments
Diff against target: 357 lines (+169/-65)
6 files modified
src/qml/AudioPlaybackBar.qml (+34/-7)
src/qml/AudioRecordingBar.qml (+42/-23)
src/qml/ComposeBar.qml (+43/-23)
src/qml/MMS/MMSAudio.qml (+38/-7)
src/qml/Stickers/StickersPicker.qml (+3/-5)
src/qml/messaging-app.qml (+9/-0)
To merge this branch: bzr merge lp://staging/~phablet-team/messaging-app/load-components-on-demand
Reviewer Review Type Date Requested Status
Arthur Mello (community) Approve
PS Jenkins bot continuous-integration Needs Fixing
Gustavo Pichorim Boiko (community) Needs Fixing
Review via email: mp+280513@code.staging.launchpad.net

Commit message

Load audio and sticker components asynchronously.

Description of the change

Load audio and sticker components asynchronously.

To post a comment you must log in.
lp://staging/~phablet-team/messaging-app/load-components-on-demand updated
483. By Tiago Salem Herrmann

expose playbackStatus to make the handle appear

484. By Tiago Salem Herrmann

load audio component asynchronously also on bubbles

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:482
http://jenkins.qa.ubuntu.com/job/messaging-app-ci/861/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/5774/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/messaging-app-vivid-i386-ci/370/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5787/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/messaging-app-ci/861/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:484
http://jenkins.qa.ubuntu.com/job/messaging-app-ci/862/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/5775/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/messaging-app-vivid-i386-ci/371/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5788/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/messaging-app-ci/862/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote :

Just one remark

review: Needs Fixing
Revision history for this message
Tiago Salem Herrmann (tiagosh) :
lp://staging/~phablet-team/messaging-app/load-components-on-demand updated
485. By Tiago Salem Herrmann

set 0 instead of false

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:485
http://jenkins.qa.ubuntu.com/job/messaging-app-ci/863/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/5780/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/messaging-app-vivid-i386-ci/372/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5793/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/messaging-app-ci/863/rebuild

review: Needs Fixing (continuous-integration)
lp://staging/~phablet-team/messaging-app/load-components-on-demand updated
486. By Gustavo Pichorim Boiko

Merge parent

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:486
http://jenkins.qa.ubuntu.com/job/messaging-app-ci/882/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/5838/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/messaging-app-vivid-i386-ci/391
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5851/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/messaging-app-ci/882/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Arthur Mello (artmello) wrote :

lgtm

review: Approve
lp://staging/~phablet-team/messaging-app/load-components-on-demand updated
487. By Gustavo Pichorim Boiko

Merge parent

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: