Media Hub

Merge lp://staging/~phablet-team/media-hub/mpris-take-2 into lp://staging/media-hub/stable

  1. mpris-take-2
  2. Merge into stable
Proposed by Alfonso Sanchez-Beato
Status: Merged
Approved by: Jim Hodapp
Approved revision: 186
Merged at revision: 159
Proposed branch: lp://staging/~phablet-team/media-hub/mpris-take-2
Merge into: lp://staging/media-hub/stable
Diff against target: 907 lines (+348/-125)
16 files modified
CMakeLists.txt (+1/-1)
README (+9/-0)
debian/changelog (+10/-0)
include/core/media/service.h (+3/-0)
src/core/media/mpris/player.h (+24/-4)
src/core/media/mpris/service.h (+1/-0)
src/core/media/player_implementation.cpp (+47/-5)
src/core/media/service_implementation.cpp (+7/-0)
src/core/media/service_implementation.h (+1/-0)
src/core/media/service_skeleton.cpp (+194/-99)
src/core/media/service_skeleton.h (+1/-0)
src/core/media/service_stub.cpp (+9/-1)
src/core/media/service_stub.h (+1/-0)
src/core/media/track_list_implementation.cpp (+11/-5)
src/core/media/track_list_skeleton.cpp (+27/-7)
src/core/media/track_list_skeleton.h (+2/-3)
To merge this branch: bzr merge lp://staging/~phablet-team/media-hub/mpris-take-2
Reviewer Review Type Date Requested Status
Jim Hodapp (community) Approve
Manuel de la Peña (community) Approve
Simon Fels Approve
Review via email: mp+271942@code.staging.launchpad.net

Commit message

Re-enable MPRIS player controls and improve background playlists

Description of the change

Re-enable MPRIS player controls and improve background playlists

To post a comment you must log in.
Revision history for this message
Simon Fels (morphis) :
Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote :

Bugs created to track the "TODO" comments:

https://bugs.launchpad.net/ubuntu/+source/media-hub/+bug/1498962
https://bugs.launchpad.net/ubuntu/+source/media-hub/+bug/1498961

Re: the trace in reset_current_player() I prefer to keep it so it is symmetrical with the one in set_current_player(). These traces are not printed very frequently and are quite useful for debugging as they happen in kind of critical moments.

Revision history for this message
Simon Fels (morphis) :
review: Approve
Revision history for this message
Manuel de la Peña (mandel) :
review: Approve
lp://staging/~phablet-team/media-hub/mpris-take-2 updated
183. By Alfonso Sanchez-Beato

[ Simon Fels ]
* Prevent us from leaking file descriptors and memory due to not releasing
  gstreamer elements correctly.
[ CI Train Bot ]
* No-change rebuild.

184. By Alfonso Sanchez-Beato

Fix changelog

Revision history for this message
Jim Hodapp (jhodapp) wrote :

A few comments inline below.

review: Needs Fixing (code)
Revision history for this message
Jim Hodapp (jhodapp) wrote :

One more change below

review: Needs Fixing
lp://staging/~phablet-team/media-hub/mpris-take-2 updated
185. By Alfonso Sanchez-Beato

Addess review comments

186. By Alfonso Sanchez-Beato

Update CanPlay and CanPause depending on whether there are items on the
playlist or not.

Revision history for this message
Jim Hodapp (jhodapp) wrote :

Looks good

review: Approve
lp://staging/~phablet-team/media-hub/mpris-take-2 updated
187. By Jim Hodapp

Merged with stable

188. By Jim Hodapp

Make sure that other sessions pause when the MPRIS play method is called.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: