Media Hub

Merge lp://staging/~phablet-team/media-hub/fix-black-video-bugs into lp://staging/media-hub

  1. fix-black-video-bugs
  2. Merge into trunk
Proposed by Jim Hodapp
Status: Merged
Approved by: Alfonso Sanchez-Beato
Approved revision: 148
Merged at revision: 147
Proposed branch: lp://staging/~phablet-team/media-hub/fix-black-video-bugs
Merge into: lp://staging/media-hub
Diff against target: 89 lines (+19/-7)
2 files modified
src/core/media/gstreamer/playbin.cpp (+17/-6)
src/core/media/gstreamer/playbin.h (+2/-1)
To merge this branch: bzr merge lp://staging/~phablet-team/media-hub/fix-black-video-bugs
Reviewer Review Type Date Requested Status
Alfonso Sanchez-Beato Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+262096@code.staging.launchpad.net

Commit message

Only send the video_dimensions_changed signal if the dimensions actually changed. Also, no longer need is_eos flag.

Description of the change

Only send the video_dimensions_changed signal if the dimensions actually changed. Also, no longer need is_eos flag.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:148
http://jenkins.qa.ubuntu.com/job/media-hub-ci/361/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/media-hub-vivid-amd64-ci/201
    SUCCESS: http://jenkins.qa.ubuntu.com/job/media-hub-vivid-armhf-ci/201
        deb: http://jenkins.qa.ubuntu.com/job/media-hub-vivid-armhf-ci/201/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/media-hub-vivid-i386-ci/201

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/media-hub-ci/361/rebuild

review: Approve (continuous-integration)
Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: