Media Hub

Merge lp://staging/~phablet-team/media-hub/fix-1533779 into lp://staging/media-hub

  1. fix-1533779
  2. Merge into trunk
Proposed by Jim Hodapp
Status: Merged
Approved by: Thomas Voß
Approved revision: 168
Merged at revision: 165
Proposed branch: lp://staging/~phablet-team/media-hub/fix-1533779
Merge into: lp://staging/media-hub
Diff against target: 261 lines (+109/-19)
8 files modified
include/core/media/player.h (+5/-0)
src/core/media/apparmor/ubuntu.cpp (+38/-10)
src/core/media/apparmor/ubuntu.h (+3/-0)
src/core/media/mpris/player.h (+8/-0)
src/core/media/player.cpp (+6/-0)
src/core/media/player_skeleton.cpp (+32/-6)
src/core/media/player_stub.cpp (+16/-2)
src/core/media/service_implementation.cpp (+1/-1)
To merge this branch: bzr merge lp://staging/~phablet-team/media-hub/fix-1533779
Reviewer Review Type Date Requested Status
Thomas Voß (community) Approve
PS Jenkins bot continuous-integration Approve
Bill Filler (community) Approve
Review via email: mp+282655@code.staging.launchpad.net

Commit message

Make sure that an apparmor profile_name of the format com.ubuntu.my-app is supported as well as improve the error handling and reporting for when a client does not have the proper apparmor permissions to play a given media URI

Description of the change

Make sure that an apparmor profile_name of the format com.ubuntu.my-app is supported as well as improve the error handling and reporting for when a client does not have the proper apparmor permissions to play a given media URI

To post a comment you must log in.
lp://staging/~phablet-team/media-hub/fix-1533779 updated
166. By Jim Hodapp

Also raise an error if insufficient apparmor permissions for open_uri extended

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:165
http://jenkins.qa.ubuntu.com/job/media-hub-ci/386/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/media-hub-vivid-amd64-ci/226
    SUCCESS: http://jenkins.qa.ubuntu.com/job/media-hub-vivid-armhf-ci/226
        deb: http://jenkins.qa.ubuntu.com/job/media-hub-vivid-armhf-ci/226/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/media-hub-vivid-i386-ci/226

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/media-hub-ci/386/rebuild

review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:166
http://jenkins.qa.ubuntu.com/job/media-hub-ci/387/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/media-hub-vivid-amd64-ci/227
    SUCCESS: http://jenkins.qa.ubuntu.com/job/media-hub-vivid-armhf-ci/227
        deb: http://jenkins.qa.ubuntu.com/job/media-hub-vivid-armhf-ci/227/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/media-hub-vivid-i386-ci/227

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/media-hub-ci/387/rebuild

review: Approve (continuous-integration)
Revision history for this message
Bill Filler (bfiller) wrote :

Tested this and functionality it's all working with silo 52. Able to record/play audio with messaging-app and playback video.

review: Approve
Revision history for this message
Thomas Voß (thomas-voss) wrote :

As per our discussion on IRC: http://pastebin.ubuntu.com/14499825/

review: Needs Fixing
lp://staging/~phablet-team/media-hub/fix-1533779 updated
167. By Jim Hodapp

Tighten up the messaging-app apparmor permission check

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:167
http://jenkins.qa.ubuntu.com/job/media-hub-ci/388/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/media-hub-vivid-amd64-ci/228
    SUCCESS: http://jenkins.qa.ubuntu.com/job/media-hub-vivid-armhf-ci/228
        deb: http://jenkins.qa.ubuntu.com/job/media-hub-vivid-armhf-ci/228/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/media-hub-vivid-i386-ci/228

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/media-hub-ci/388/rebuild

review: Approve (continuous-integration)
lp://staging/~phablet-team/media-hub/fix-1533779 updated
168. By Jim Hodapp

Remove app_id_ since it isn't used

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:168
http://jenkins.qa.ubuntu.com/job/media-hub-ci/389/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/media-hub-vivid-amd64-ci/229
    SUCCESS: http://jenkins.qa.ubuntu.com/job/media-hub-vivid-armhf-ci/229
        deb: http://jenkins.qa.ubuntu.com/job/media-hub-vivid-armhf-ci/229/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/media-hub-vivid-i386-ci/229

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/media-hub-ci/389/rebuild

review: Approve (continuous-integration)
Revision history for this message
Thomas Voß (thomas-voss) wrote :

LGTM.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: