Merge lp://staging/~phablet-team/indicator-network/fix-nm1.2-hotspot into lp://staging/indicator-network
Proposed by
Tony Espy
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Pete Woods | ||||
| Approved revision: | 588 | ||||
| Merged at revision: | 590 | ||||
| Proposed branch: | lp://staging/~phablet-team/indicator-network/fix-nm1.2-hotspot | ||||
| Merge into: | lp://staging/indicator-network | ||||
| Diff against target: |
14 lines (+0/-3) 1 file modified
src/indicator/nmofono/hotspot-manager.cpp (+0/-3) |
||||
| To merge this branch: | bzr merge lp://staging/~phablet-team/indicator-network/fix-nm1.2-hotspot | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| PS Jenkins bot (community) | continuous-integration | Needs Fixing | |
| Pete Woods (community) | Approve | ||
|
Review via email:
|
|||
Commit message
hotspot: Don't create NM ipv4 settings with empty values.
Description of the change
This change updates the hotspot code to not include ipv4 settings which have empty values.
This fixes an issue with NetworkManager 1.2 which rejects an improperly specified ipv4.dns value:
void nmofono:
Failed to add connection: "ipv4.dns: can't set property of type 'au' from value of type 'as'"
To post a comment you must log in.
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| Pete Woods (pete-woods) | # |
review:
Approve
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
FAILED: Continuous integration, rev:579
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
Click here to trigger a rebuild:
http://