Merge lp://staging/~phablet-team/history-service/sort_by_multiple_fields into lp://staging/history-service/staging
Proposed by
Gustavo Pichorim Boiko
| Status: | Merged |
|---|---|
| Approved by: | Tiago Salem Herrmann |
| Approved revision: | 263 |
| Merged at revision: | 260 |
| Proposed branch: | lp://staging/~phablet-team/history-service/sort_by_multiple_fields |
| Merge into: | lp://staging/history-service/staging |
| Prerequisite: | lp://staging/~phablet-team/history-service/mark_threads_as_read |
| Diff against target: |
115 lines (+50/-8) 4 files modified
Ubuntu/History/historymodel.cpp (+12/-4) plugins/sqlite/sqlitehistoryeventview.cpp (+8/-1) plugins/sqlite/sqlitehistorythreadview.cpp (+8/-1) tests/plugins/sqlite/SqliteEventViewTest.cpp (+22/-2) |
| To merge this branch: | bzr merge lp://staging/~phablet-team/history-service/sort_by_multiple_fields |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Tiago Salem Herrmann (community) | Approve | ||
| Gustavo Pichorim Boiko (community) | Needs Fixing | ||
|
Review via email:
|
|||
This proposal supersedes a proposal from 2017-02-07.
Commit message
Allow pass multiple fields on sort clause.
Description of the change
Allow pass multiple fields on sort clause.
To post a comment you must log in.
Revision history for this message
| Renato Araujo Oliveira Filho (renatofilho) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Just one request, looks good otherwise.