history-service

Merge lp://staging/~phablet-team/history-service/fix_qtdbus_5.6 into lp://staging/history-service/staging

  1. fix_qtdbus_5.6
  2. Merge into staging
Proposed by Gustavo Pichorim Boiko
Status: Merged
Approved by: Roberto Mier Escandon
Approved revision: 232
Merged at revision: 242
Proposed branch: lp://staging/~phablet-team/history-service/fix_qtdbus_5.6
Merge into: lp://staging/history-service/staging
Prerequisite: lp://staging/~phablet-team/history-service/re-enable_disable_tests
Diff against target: 51 lines (+10/-12)
2 files modified
daemon/historyservicedbus.cpp (+5/-6)
tests/common/mock/mockconnectiondbus.cpp (+5/-6)
To merge this branch: bzr merge lp://staging/~phablet-team/history-service/fix_qtdbus_5.6
Reviewer Review Type Date Requested Status
Roberto Mier Escandon (community) Approve
system-apps-ci-bot continuous-integration Pending
Review via email: mp+309398@code.staging.launchpad.net

This proposal supersedes a proposal from 2016-09-19.

Commit message

Adapt the registration of objects and services to the way QtDBus works from 5.6.x on.

Description of the change

Adapt the registration of objects and services to the way QtDBus works from 5.6.x on.

To post a comment you must log in.
Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:232
https://jenkins.canonical.com/system-apps/job/lp-history-service-ci/21/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-apps/job/build/1562/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/1562
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1409
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1409/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1409/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=yakkety/1409/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1409
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1409/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1409
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1409/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=yakkety/1409
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=yakkety/1409/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/1409
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/1409/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/1409/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=yakkety/1409/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-history-service-ci/21/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Roberto Mier Escandon (rmescandon) wrote :

Tests are not aligned with telepathy 0.9.7

A question: Why is it needed register the service after the object?

review: Needs Fixing
Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote :

> Tests are not aligned with telepathy 0.9.7
>
> A question: Why is it needed register the service after the object?

So, QtDBus's internal implementation is now using threads, so if you call registerService(), it takes effect immediately (which would cause the service to be exposed on DBus without having all the required objects registered). That's why now we have to register all objects before registering the service on DBus.

Revision history for this message
Roberto Mier Escandon (rmescandon) wrote :

not needed to be aligned with tp-qt 0.9.7 in this branch. lgtm.
understood the order of registering

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: