Merge lp://staging/~phablet-team/history-service/dont-merge-different-chattype into lp://staging/history-service/staging

Proposed by Tiago Salem Herrmann
Status: Merged
Approved by: Gustavo Pichorim Boiko
Approved revision: 249
Merged at revision: 249
Proposed branch: lp://staging/~phablet-team/history-service/dont-merge-different-chattype
Merge into: lp://staging/history-service/staging
Diff against target: 10 lines (+1/-0)
1 file modified
plugins/sqlite/sqlitehistoryplugin.cpp (+1/-0)
To merge this branch: bzr merge lp://staging/~phablet-team/history-service/dont-merge-different-chattype
Reviewer Review Type Date Requested Status
Gustavo Pichorim Boiko (community) Approve
Review via email: mp+311155@code.staging.launchpad.net

This proposal supersedes a proposal from 2016-11-16.

Commit message

- Fix broken tests with latest changes.
- Set ChatType correctly when using createThreadForParticipants()

Description of the change

- Fix broken tests with latest changes.
- Set ChatType correctly when using createThreadForParticipants()

To post a comment you must log in.
Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote : Posted in a previous version of this proposal

Looks good!

review: Approve
Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote :

Looks good!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: