Merge lp://staging/~phablet-team/dialer-app/voip_support into lp://staging/dialer-app
Proposed by
Gustavo Pichorim Boiko
| Status: | Superseded |
|---|---|
| Proposed branch: | lp://staging/~phablet-team/dialer-app/voip_support |
| Merge into: | lp://staging/dialer-app |
| Diff against target: |
165 lines (+70/-2) 3 files modified
src/qml/DialerPage/DialerPage.qml (+32/-1) src/qml/DialerPage/KeypadEntry.qml (+27/-0) src/qml/LiveCallPage/LiveCall.qml (+11/-1) |
| To merge this branch: | bzr merge lp://staging/~phablet-team/dialer-app/voip_support |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Renato Araujo Oliveira Filho (community) | Approve | ||
| system-apps-ci-bot | continuous-integration | Needs Fixing | |
|
Review via email:
|
|||
This proposal has been superseded by a proposal from 2017-03-22.
Commit message
Adapt to work with VOIP accounts.
Description of the change
Adapt to work with VOIP accounts.
To post a comment you must log in.
Revision history for this message
| Renato Araujo Oliveira Filho (renatofilho) wrote | # |
review:
Needs Information
Revision history for this message
| Gustavo Pichorim Boiko (boiko) wrote | # |
Revision history for this message
| system-apps-ci-bot (system-apps-ci-bot) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| Renato Araujo Oliveira Filho (renatofilho) wrote | # |
review:
Approve
Unmerged revisions
- 566. By Gustavo Pichorim Boiko
-
Disable the audio output button in case there is no choice.
- 565. By Gustavo Pichorim Boiko
-
Add a comment about the focus workaround.
- 564. By Gustavo Pichorim Boiko
-
Fix keyboard DTMF typing during a call.
- 563. By Gustavo Pichorim Boiko
-
When enter is pressed, place the call
- 562. By Gustavo Pichorim Boiko
-
Forward input on livecall too
- 561. By Gustavo Pichorim Boiko
-
use the identifier from the contactwatcher
- 560. By Gustavo Pichorim Boiko
-
Disable focus on the sim selector
- 559. By Gustavo Pichorim Boiko
-
handle keyboard input
- 558. By Gustavo Pichorim Boiko
-
Revert previous changes: they were done in a separate branch.
- 557. By Gustavo Pichorim Boiko
-
Elide the remote id in the live call screen
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Some small comments.