Merge lp://staging/~phablet-team/dialer-app/phone_settings into lp://staging/dialer-app
Proposed by
Gustavo Pichorim Boiko
| Status: | Superseded |
|---|---|
| Proposed branch: | lp://staging/~phablet-team/dialer-app/phone_settings |
| Merge into: | lp://staging/dialer-app |
| Prerequisite: | lp://staging/~phablet-team/dialer-app/expand-dialer |
| Diff against target: |
3160 lines (+2439/-120) 28 files modified
debian/dialer-app.install (+1/-0) po/dialer-app.pot (+253/-111) src/qml/CMakeLists.txt (+1/-0) src/qml/DialerPage/DialerPage.qml (+11/-2) src/qml/LiveCallPage/LiveCall.qml (+11/-3) src/qml/SettingsPage/AccountSettings/CMakeLists.txt (+6/-0) src/qml/SettingsPage/AccountSettings/SipNumberRewrite.qml (+177/-0) src/qml/SettingsPage/AccountSettings/sip.qml (+30/-0) src/qml/SettingsPage/CMakeLists.txt (+8/-0) src/qml/SettingsPage/CallForwardItem.qml (+240/-0) src/qml/SettingsPage/CallForwarding.qml (+393/-0) src/qml/SettingsPage/CallWaiting.qml (+108/-0) src/qml/SettingsPage/KeyboardRectangle.qml (+77/-0) src/qml/SettingsPage/MultiSim.qml (+113/-0) src/qml/SettingsPage/NoSims.qml (+46/-0) src/qml/SettingsPage/Ofono.qml (+69/-0) src/qml/SettingsPage/OnlineAccountsHelper.qml (+96/-0) src/qml/SettingsPage/ServiceInfo.qml (+133/-0) src/qml/SettingsPage/Services.qml (+74/-0) src/qml/SettingsPage/SettingsItemTitle.qml (+44/-0) src/qml/SettingsPage/SettingsPage.qml (+158/-0) src/qml/SettingsPage/SettingsTextField.qml (+29/-0) src/qml/SettingsPage/SingleSim.qml (+69/-0) src/qml/SettingsPage/VCardParser.qml (+55/-0) src/qml/SettingsPage/callForwardingUtils.js (+126/-0) src/qml/SettingsPage/dateUtils.js (+69/-0) src/qml/SettingsPage/phone.settings (+24/-0) src/qml/dialer-app.qml (+18/-4) |
| To merge this branch: | bzr merge lp://staging/~phablet-team/dialer-app/phone_settings |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Renato Araujo Oliveira Filho (community) | Needs Fixing | ||
|
Review via email:
|
|||
This proposal has been superseded by a proposal from 2017-03-22.
Commit message
Move the phone settings from ubuntu-
Description of the change
Move the phone settings from ubuntu-
To post a comment you must log in.
Revision history for this message
| Renato Araujo Oliveira Filho (renatofilho) wrote | # |
review:
Needs Fixing
Unmerged revisions
- 574. By Gustavo Pichorim Boiko
-
Add a TODO file with the pending items.
- 573. By Gustavo Pichorim Boiko
-
Update to QtQuick 2.4
- 572. By Gustavo Pichorim Boiko
-
Remove unused file.
- 571. By Gustavo Pichorim Boiko
-
Use the initial number when available to do contact matching.
This is necessary as VOIP calls may rewrite the phone number causing contact
match to fail. - 570. By Gustavo Pichorim Boiko
-
Display settings for all accounts, not just the online ones
- 569. By Gustavo Pichorim Boiko
-
Disable area code
- 568. By Gustavo Pichorim Boiko
-
Fix reading the settings.
- 567. By Gustavo Pichorim Boiko
-
Adapt the number rewrite UI to the new approach.
- 566. By Gustavo Pichorim Boiko
-
Use correct title for settings page
- 565. By Gustavo Pichorim Boiko
-
Add prefix settings for VOIP accounts.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Should we use the new ListItem to correct handle keyboard navigation and other theme related features?
Some small inline comments.