QA Regression Testing

Merge ~pfsmorigo/qa-regression-testing:pfsmorigo/test_ua_client into qa-regression-testing:master

  1. Git
  2. lp:~pfsmorigo/qa-regression-testing
  3. pfsmorigo/test_ua_client
  4. Merge into master
Proposed by Paulo Flabiano Smorigo
Status: Merged
Merge reported by: Paulo Flabiano Smorigo
Merged at revision: a362d97d91ba4f4cd5854ee0d6475aa8d061768f
Proposed branch: ~pfsmorigo/qa-regression-testing:pfsmorigo/test_ua_client
Merge into: qa-regression-testing:master
Diff against target: 229 lines (+223/-0)
1 file modified
ua_testing/test_ua_client.py (+223/-0)
Reviewer Review Type Date Requested Status
Emilia Torino Needs Fixing
Steve Beattie Approve
Review via email: mp+417598@code.staging.launchpad.net

Description of the change

This is a continuation of https://code.launchpad.net/~pfsmorigo/ubuntu-cve-tracker/+git/ubuntu-cve-tracker/+merge/405663

I move the script here as Alex suggested. I rewrote the script to use schroot sessions, much more stable and currently, if the test failed, you have the chance to enter the schroot and investigate the failure.

My plan is to add the integration to publish-usn-to-website-api.py in UCT after this merge is completed.

To post a comment you must log in.
Revision history for this message
Steve Beattie (sbeattie) wrote :

So, I am happy to incorporate this is as-is and iterate on improving it in tree.

Some comments inline, none blocking for landing per above.

review: Approve
Revision history for this message
Alex Murray (alexmurray) wrote :

Agreed - perhaps it is my COVID-addled brain, but is there a reason this couldn't be reworked to just be a regular package testing script, and then be named scripts/test-ubuntu-advantage-tools.py?

Revision history for this message
Emilia Torino (emitorino) wrote :

2 minor comments but otherwise this is great. I suggest we incorporate the requested changes (which are not major ones) and prevent adding technical debt on this new script. Thanks!

review: Needs Fixing
Revision history for this message
Paulo Flabiano Smorigo (pfsmorigo) wrote :

Just some comments before I push a new version.

Revision history for this message
Paulo Flabiano Smorigo (pfsmorigo) wrote :

To test:

export UA_KEY=xxxx
./test_ua_client.py ./5292-1.json
or
./test_ua_client.py 5292-1

You can increase the verbosity like:
./test_ua_client.py -vvvv 5292-1

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches