Linaro Toolchain WG Web

Merge lp://staging/~pfalcon/tcwg-web/handle-lava-errors into lp://staging/tcwg-web

  1. handle-lava-errors
  2. Merge into trunk
Proposed by Paul Sokolovsky
Status: Merged
Merged at revision: 247
Proposed branch: lp://staging/~pfalcon/tcwg-web/handle-lava-errors
Merge into: lp://staging/tcwg-web
Diff against target: 93 lines (+32/-6)
3 files modified
common.py (+7/-2)
lava.py (+10/-1)
scheduler.py (+15/-3)
To merge this branch: bzr merge lp://staging/~pfalcon/tcwg-web/handle-lava-errors
Reviewer Review Type Date Requested Status
Matthew Gretton-Dann Approve
Review via email: mp+165437@code.staging.launchpad.net

Description of the change

This fixes CBuild 500 Internal Errors when LAVA request fails, and shows a proper error message to the user instead.

To post a comment you must log in.
Revision history for this message
Will Newton (will-newton) wrote :

Line 10 should say "if successful". Other than that looks ok to me, but I am not familiar with LAVA internals.

Revision history for this message
Matthew Gretton-Dann (matthew-gretton-dann) wrote :

Looks good to me.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches