Merge lp://staging/~pfalcon/linaro-android-build-tools/revamp-build-copycat into lp://staging/linaro-android-build-tools

Code changes looks good. +1.
It would be good if there were instructions on how to test this.

On Wed, May 16, 2012 at 7:40 PM, Paul Sokolovsky <<email address hidden>
> wrote:

> Paul Sokolovsky has proposed merging
> lp:~pfalcon/linaro-android-build-tools/revamp-build-copycat into
> lp:linaro-android-build-tools.
>
> Requested reviews:
> Linaro Infrastructure (linaro-infrastructure)
>
> For more details, see:
>
> https://code.launchpad.net/~pfalcon/linaro-android-build-tools/revamp-build-copycat/+merge/105981<https://code.launchpad.net/%7Epfalcon/linaro-android-build-tools/revamp-build-copycat/+merge/105981>
>
> Revamp support for BUILD_COPYCAT on android-build, which can be used to
> skip building artifacts, and instead snatch them from some other build.
> Useful for testing LAVA submission, etc.
>
> --
>
> https://code.launchpad.net/~pfalcon/linaro-android-build-tools/revamp-build-copycat/+merge/105981<https://code.launchpad.net/%7Epfalcon/linaro-android-build-tools/revamp-build-copycat/+merge/105981>
> Your team Linaro Infrastructure is requested to review the proposed merge
> of lp:~pfalcon/linaro-android-build-tools/revamp-build-copycat into
> lp:linaro-android-build-tools.
>
> === modified file 'build-scripts/helpers'
> --- build-scripts/helpers 2012-03-08 11:30:05 +0000
> +++ build-scripts/helpers 2012-05-16 14:09:23 +0000
> @@ -70,9 +70,21 @@
> #echo `get_version binutils-2.20.1.tar.bz2`
> # 2.20.1
>
> +#
> +# Download another builds's artifacts, as if they were
> +# produced by this build. Used for testing, trigger by BUILD_COPYCAT
> +# build config setting.
> +#
> download_another_build () {
> + local baseurl
> + if ! echo "$1" | grep '//' >/dev/null; then
> + baseurl="http://snapshots.linaro.org/android/$1"
> + else
> + baseurl=$1
> + fi
> + echo $baseurl
> + return
> local dir=out/target/product/$TARGET_PRODUCT
> - local baseurl="http://android-build.linaro.org/builds/$1"
> mkdir -p $dir
> pushd $dir
> wget --quiet "$baseurl/target/product/$TARGET_PRODUCT/boot.tar.bz2"
>
>
>

--
Thanks and Regards,
Deepti

I don't like the 'return' statement in the middle of the function. The code below will not be executed which means it can be removed. Or it must be executed which means 'return' statement should not be here.
Otherwise looks good.

Good catch, it's debugging code.