Merge lp://staging/~pfalcon/linaro-android-build-tools/new-pub into lp://staging/linaro-android-build-tools

Proposed by Paul Sokolovsky
Status: Merged
Approved by: Tyler Baker
Approved revision: 645
Merged at revision: 585
Proposed branch: lp://staging/~pfalcon/linaro-android-build-tools/new-pub
Merge into: lp://staging/linaro-android-build-tools
Diff against target: 630 lines (+445/-131)
8 files modified
utils/mangle-jobs/builders.xml (+12/-131)
utils/new-publish/README (+50/-0)
utils/new-publish/propagate.py (+66/-0)
utils/new-publish/publib.py (+103/-0)
utils/new-publish/publish (+46/-0)
utils/new-publish/setup.sh (+116/-0)
utils/new-publish/test/data/top_file (+1/-0)
utils/new-publish/test/test_publish.py (+51/-0)
To merge this branch: bzr merge lp://staging/~pfalcon/linaro-android-build-tools/new-pub
Reviewer Review Type Date Requested Status
Tyler Baker Approve
Linaro Automation & Validation Pending
Review via email: mp+159373@code.staging.launchpad.net

Description of the change

This is prototype of new build system independent interface for publishing build artifacts, implement to address capacity problems on androdi-build.

When reviewing this, please keep in mind following:

1. This is a prototype, so there're lots to improve.
2. This is critical fix for android-build, in strong need for Android team, which needs to deliver RC by the end of week. So, this rather be deployed today.

Otherwise, this implements publishing API abstracted to a single script (from client's point of view). Underlyingly, it uses the same restricted SFTP publishing infrastructure as was used previously, just more efficiently (build time down to ~4min from 20+min).

Suggested direction of review: security side of things.

To post a comment you must log in.
Revision history for this message
Paul Sokolovsky (pfalcon) wrote :
Revision history for this message
Paul Sokolovsky (pfalcon) wrote :

Please note: some cleanups and migration script is still WIP, but the functionality is there.

645. By Paul Sokolovsky

Update builders section for new publisher migration.

Revision history for this message
Paul Sokolovsky (pfalcon) wrote :

Added migration script.

Revision history for this message
Tyler Baker (tyler-baker) wrote :

+1 Approved

1) Looks good for an prototype.
2) In the furture, I would like to explore more secure options for external publishing access.

review: Approve
Revision history for this message
Paul Sokolovsky (pfalcon) wrote :

> 2) In the furture, I would like to explore more secure options for external publishing access.

Sure. This implementation is at least similar to what we had before. Full-fledged publishing system could use better options, like limited-use auth tokens (as mentioned in README).

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches