Prometheus Openstack Exporter Charm

Merge ~peter-sabaini/charm-prometheus-openstack-exporter:add-kstv3-creds into ~prometheus-charmers/charm-prometheus-openstack-exporter/+git/prometheus-openstack-exporter-charm:master

  1. Git
  2. lp:~peter-sabaini/charm-prometheus-openstack-exporter
  3. add-kstv3-creds
  4. Merge into master
Proposed by Peter Sabaini
Status: Merged
Merged at revision: 5dfa9699807fdb1e49f027f8df76a3823f745ff9
Proposed branch: ~peter-sabaini/charm-prometheus-openstack-exporter:add-kstv3-creds
Merge into: ~prometheus-charmers/charm-prometheus-openstack-exporter/+git/prometheus-openstack-exporter-charm:master
Diff against target: 41 lines (+22/-0)
2 files modified
reactive/openstack_exporter.py (+12/-0)
templates/admin.novarc (+10/-0)
Reviewer Review Type Date Requested Status
James Hebden (community) Approve
Review via email: mp+334541@code.staging.launchpad.net

Commit message

Add keystone v3 creds

Description of the change

Render keystone v3 creds into novarc if provided

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
James Hebden (ec0) wrote :

LGTM

I'll also file a separate bug, because even prior to this MP is seems that getting novarc from a v3 keystone via relation doesn't work - at least this will give us a way to get it working with v3 without manual hacks for now.

review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change must be approved by a member of one of the following teams:
 - canonical-sysadmins
Setting status to needs review.

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches