Merge lp://staging/~peter-sabaini/charm-helpers/charm-helpers-get_address_in_network into lp://staging/charm-helpers
Proposed by
Peter Sabaini
| Status: | Merged |
|---|---|
| Merged at revision: | 731 |
| Proposed branch: | lp://staging/~peter-sabaini/charm-helpers/charm-helpers-get_address_in_network |
| Merge into: | lp://staging/charm-helpers |
| Diff against target: |
20 lines (+5/-5) 1 file modified
charmhelpers/contrib/network/ip.py (+5/-5) |
| To merge this branch: | bzr merge lp://staging/~peter-sabaini/charm-helpers/charm-helpers-get_address_in_network |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Jorge Niedbalski (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
When searching for network, check all ipv4 addr for an iface
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
LGTM, I added an additional unit test to cover your change.