Charm Helpers

Merge lp://staging/~peter-sabaini/charm-helpers/bcache-helpers into lp://staging/charm-helpers

  1. bcache-helpers
  2. Merge into devel
Proposed by Peter Sabaini
Status: Merged
Merged at revision: 759
Proposed branch: lp://staging/~peter-sabaini/charm-helpers/bcache-helpers
Merge into: lp://staging/charm-helpers
Diff against target: 172 lines (+163/-0)
2 files modified
charmhelpers/contrib/storage/linux/bcache.py (+74/-0)
tests/contrib/storage/test_bcache.py (+89/-0)
To merge this branch: bzr merge lp://staging/~peter-sabaini/charm-helpers/bcache-helpers
Reviewer Review Type Date Requested Status
Stuart Bishop (community) Approve
Review via email: mp+323616@code.staging.launchpad.net

Description of the change

Add helper module for bcache devices

To post a comment you must log in.
Revision history for this message
Stuart Bishop (stub) wrote :

Mostly good. A few inline comments. Let me know here if I should merge.

review: Approve
lp://staging/~peter-sabaini/charm-helpers/bcache-helpers updated
741. By Peter Sabaini

Merge Tim Van Steenburgh 2017-07-05 v0.17.0

742. By Peter Sabaini

Cleanup test and some doc bits

Revision history for this message
Peter Sabaini (peter-sabaini) wrote :

Hey - apologies, this fell through the cracks.

Thanks for the valuable suggestions, I've updated the MP as requested. Please merge if this is ok

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches