qmenumodel

Merge lp://staging/~pete-woods/qmenumodel/fix-memory-leak into lp://staging/~phablet-team/qmenumodel/trunk

  1. fix-memory-leak
  2. Merge into trunk
Proposed by Pete Woods
Status: Merged
Approved by: Pete Woods
Approved revision: 90
Merged at revision: 90
Proposed branch: lp://staging/~pete-woods/qmenumodel/fix-memory-leak
Merge into: lp://staging/~phablet-team/qmenumodel/trunk
Diff against target: 11 lines (+1/-0)
1 file modified
libqmenumodel/src/unitymenumodel.cpp (+1/-0)
To merge this branch: bzr merge lp://staging/~pete-woods/qmenumodel/fix-memory-leak
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Lars Karlitski (community) Approve
Review via email: mp+186023@code.staging.launchpad.net

Commit message

Fix memory leak in unitymenumodel

The items sequence is not being freed in the destructor.

Description of the change

Fix memory leak in unitymenumodel

The items sequence is not being freed in the destructor.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:90
http://jenkins.qa.ubuntu.com/job/qmenumodel-ci/34/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qmenumodel-saucy-amd64-ci/31
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qmenumodel-saucy-armhf-ci/31
        deb: http://jenkins.qa.ubuntu.com/job/qmenumodel-saucy-armhf-ci/31/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins:8080/job/qmenumodel-ci/34/rebuild

review: Approve (continuous-integration)
Revision history for this message
Pete Woods (pete-woods) wrote :

Perhaps there is a good reason for this sequence not being destroyed that I don't understand due to lack of familiarity with the codebase?

Revision history for this message
Lars Karlitski (larsu) wrote :

> Perhaps there is a good reason for this sequence not being destroyed that I
> don't understand due to lack of familiarity with the codebase?

Nope, this is a legit memory leak. Good catch. Thanks!

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/qmenumodel-autolanding/16/
Executed test runs:
    FAILURE: http://s-jenkins:8080/job/generic-cleanup-mbs/2262/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qmenumodel-saucy-amd64-autolanding/14/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/qmenumodel-saucy-armhf-autolanding/14/console

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches