net-cpp

Merge lp://staging/~pete-woods/net-cpp/base64 into lp://staging/net-cpp

  1. base64
  2. Merge into trunk
Proposed by Pete Woods
Status: Merged
Approved by: Thomas Voß
Approved revision: 31
Merged at revision: 30
Proposed branch: lp://staging/~pete-woods/net-cpp/base64
Merge into: lp://staging/net-cpp
Diff against target: 183 lines (+111/-1)
6 files modified
debian/control (+1/-0)
include/core/net/http/client.h (+6/-0)
src/CMakeLists.txt (+1/-1)
src/core/net/http/impl/curl/client.cpp (+57/-0)
src/core/net/http/impl/curl/client.h (+4/-0)
tests/http_client_test.cpp (+42/-0)
To merge this branch: bzr merge lp://staging/~pete-woods/net-cpp/base64
Reviewer Review Type Date Requested Status
Thomas Voß (community) Approve
Ubuntu Phablet Team Pending
Review via email: mp+222055@code.staging.launchpad.net

Commit message

Add support for base64 encoding / decoding

Description of the change

Add support for base64 encoding / decoding

To post a comment you must log in.
lp://staging/~pete-woods/net-cpp/base64 updated
30. By Pete Woods

Formatting cleanup

Revision history for this message
Thomas Voß (thomas-voss) wrote :

I think the symbols file needs an update. Did you try running a package build?

review: Needs Information
Revision history for this message
Pete Woods (pete-woods) wrote :

Yes, indeed I have it installed now. Wonder why it didn't fail...

lp://staging/~pete-woods/net-cpp/base64 updated
31. By Pete Woods

Remove unnecessary whitespace

Revision history for this message
Pete Woods (pete-woods) wrote :

Indeed, the symbols file is missing most of the stuff I'd expect it to contain, e.g. url_escape doesn't appear in it. Maybe it has the wrong name, and is being ignored?

Revision history for this message
Thomas Voß (thomas-voss) wrote :

> Indeed, the symbols file is missing most of the stuff I'd expect it to
> contain, e.g. url_escape doesn't appear in it. Maybe it has the wrong name,
> and is being ignored?

Might well be the case, and we can fix that in a follow-up MP. With that: LGTM.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches