Network Menu

Merge lp://staging/~pete-woods/indicator-network/sim-unlock-debugging-lp1465214 into lp://staging/indicator-network/15.10

sim-unlock-debugging-lp1465214
Merge into trunk.15.10

Proposed by Pete Woods on 2015-06-16

Status:

Merged

Approved by:

Charles Kerr on 2015-06-25

Approved revision:

499

Merged at revision:

496

Proposed branch:

lp://staging/~pete-woods/indicator-network/sim-unlock-debugging-lp1465214

Merge into:

lp://staging/indicator-network/15.10

Diff against target:

211 lines (+75/-3)

4 files modified

src/indicator/nmofono/manager-impl.cpp (+24/-2)
src/indicator/nmofono/wwan/modem.cpp (+40/-0)
src/indicator/nmofono/wwan/modem.h (+6/-0)
src/indicator/sim-unlock-dialog.cpp (+5/-1)

To merge this branch:

bzr merge lp://staging/~pete-woods/indicator-network/sim-unlock-debugging-lp1465214

Critical

Invalid

Link a bug report

Reviewer	Review Type	Date Requested	Status
Charles Kerr (community)		2015-06-16	Approve on 2015-06-25
PS Jenkins bot (community)	continuous-integration		Needs Fixing on 2015-06-18
Review via email: mp+262108@code.staging.launchpad.net

Commit message

Wait for SIM Manager interface to be fully initialised before we try and unlock any SIMs

Description of the change

Wait for SIM Manager interface to be fully initialised before we try and unlock any SIMs

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-06-16:

FAILED: Continuous integration, rev:496
http://jenkins.qa.ubuntu.com/job/indicator-network-ci/349/
Executed test runs:
FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-network-wily-amd64-ci/2/console
FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-network-wily-armhf-ci/2/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-network-ci/349/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~pete-woods/indicator-network/sim-unlock-debugging-lp1465214 updated on 2015-06-17

496. By Pete Woods on 2015-06-17: Wait for all SimManager properties to be set before declaring it valid
497. By Pete Woods on 2015-06-17: Log when we launch the unlock dialogue

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-06-17:

FAILED: Continuous integration, rev:497
http://jenkins.qa.ubuntu.com/job/indicator-network-ci/350/
Executed test runs:
FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-network-wily-amd64-ci/3/console
FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-network-wily-armhf-ci/3/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-network-ci/350/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~pete-woods/indicator-network/sim-unlock-debugging-lp1465214 updated on 2015-06-18

498. By Pete Woods on 2015-06-18: Schedule the modem to tell us about the unlock, don't let it spam us
499. By Pete Woods on 2015-06-18: Just warn, rather than throw