Network Menu

Merge lp://staging/~pete-woods/indicator-network/dual-sim-status into lp://staging/indicator-network/15.10

  1. dual-sim-status
  2. Merge into trunk.15.10
Proposed by Pete Woods
Status: Merged
Approved by: Pete Woods
Approved revision: 499
Merged at revision: 498
Proposed branch: lp://staging/~pete-woods/indicator-network/dual-sim-status
Merge into: lp://staging/indicator-network/15.10
Diff against target: 310 lines (+79/-17)
6 files modified
CMakeLists.txt (+2/-0)
src/indicator/icons.cpp (+1/-0)
src/indicator/menuitems/wwan-link-item.cpp (+15/-2)
tests/integration/indicator-network-test-base.cpp (+46/-7)
tests/integration/indicator-network-test-base.h (+5/-1)
tests/integration/test-indicator.cpp (+10/-7)
To merge this branch: bzr merge lp://staging/~pete-woods/indicator-network/dual-sim-status
Reviewer Review Type Date Requested Status
Marcus Tomlinson (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+262454@code.staging.launchpad.net

Commit message

Implement dual SIM status

Description of the change

Implement dual SIM status

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:496
http://jenkins.qa.ubuntu.com/job/indicator-network-ci/352/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-network-wily-amd64-ci/5/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-network-wily-armhf-ci/5/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-network-ci/352/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Marcus Tomlinson (marcustomlinson) wrote :

Change looks good to me. Build failure looks odd though, CI fail?

review: Needs Information
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:497
http://jenkins.qa.ubuntu.com/job/indicator-network-ci/353/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-network-wily-amd64-ci/6
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-network-wily-armhf-ci/6
        deb: http://jenkins.qa.ubuntu.com/job/indicator-network-wily-armhf-ci/6/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-network-ci/353/rebuild

review: Approve (continuous-integration)
Revision history for this message
Marcus Tomlinson (marcustomlinson) wrote :

Awesome. +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches