Merge lp://staging/~percona-toolkit-dev/percona-toolkit/fix-i26211-1058285-821722-implicit-ansi_quotes into lp://staging/percona-toolkit/2.1

Proposed by Brian Fraser
Status: Superseded
Proposed branch: lp://staging/~percona-toolkit-dev/percona-toolkit/fix-i26211-1058285-821722-implicit-ansi_quotes
Merge into: lp://staging/percona-toolkit/2.1
Prerequisite: lp://staging/~percona-toolkit-dev/percona-toolkit/portable-test-suite
Diff against target: 521 lines (+236/-91)
17 files modified
bin/pt-archiver (+7/-6)
bin/pt-duplicate-key-checker (+7/-6)
bin/pt-find (+7/-6)
bin/pt-heartbeat (+7/-6)
bin/pt-index-usage (+7/-6)
bin/pt-kill (+7/-6)
bin/pt-online-schema-change (+10/-10)
bin/pt-query-advisor (+7/-6)
bin/pt-query-digest (+7/-6)
bin/pt-table-checksum (+7/-6)
bin/pt-table-sync (+7/-6)
bin/pt-table-usage (+7/-6)
bin/pt-upgrade (+7/-6)
lib/TableParser.pm (+13/-8)
t/pt-online-schema-change/ansi_quotes.t (+96/-0)
t/pt-online-schema-change/bugs.t (+0/-1)
t/pt-online-schema-change/samples/sql-mode-bug-1058285.sql (+33/-0)
To merge this branch: bzr merge lp://staging/~percona-toolkit-dev/percona-toolkit/fix-i26211-1058285-821722-implicit-ansi_quotes
Reviewer Review Type Date Requested Status
Brian Fraser (community) Approve
Daniel Nichter Pending
Review via email: mp+128069@code.staging.launchpad.net

This proposal has been superseded by a proposal from 2012-11-01.

To post a comment you must log in.
400. By Daniel Nichter

Don't localize EVAL_ERROR so errors in deeper contexts aren't wiped out when exec returns to outter context.

401. By Daniel Nichter

Merge fix-ptc-pxc-bug-1062563.

402. By Daniel Nichter

Merge fix-failing-pingback-tests.

403. By Daniel Nichter

Make pt-table-checksum/run_time.t more reliable.

404. By Daniel Nichter

Merge add-ouptput-col-headers-bug-1059757.

405. By Daniel Nichter

Fix link in pt-visual-explain docs to missing file on maatkit.org.

406. By Daniel Nichter

Make HTTPMicro.t test names unique.

407. By Daniel Nichter

Merge fix-run-time-bug-1043438.

408. By Daniel Nichter

Merge 2.1.5-release.

409. By Brian Fraser <email address hidden>

Merged raw-log-parser-percona-22371

410. By Brian Fraser <email address hidden>

Merged fix-903229-pt-mysql-summary-case-insensitivity-for-engines

411. By Brian Fraser

Fix for customer issue 26211 ($avg_rate might be zero), plus a fix for bug 1058285 (also related to 26211), and an emergent part of 821722: Several sql_modes implicitly turn on ANSI_QUOTES

Revision history for this message
Brian Fraser (fraserbn) :
review: Approve
Revision history for this message
Daniel Nichter (daniel-nichter) wrote :

I think the customer's particular issue was already fixed in 2.1.4. I've asked someone to verify this.

412. By Daniel Nichter

Set sql_mode='' before SHOW CREATE TABLE--don't bother with replacing certain values. Move and rewrite tests to ansi_quotes.t.

413. By Daniel Nichter

Update TableParser in all tools.

414. By Daniel Nichter

Test that SQL_MODE isn't changed.

415. By Brian Fraser

Added a test for the second bug in customer issue 26211

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches