Merge lp://staging/~percona-toolkit-dev/percona-toolkit/enable-version-check-by-default into lp://staging/percona-toolkit/2.2

Proposed by Daniel Nichter
Status: Merged
Approved by: Daniel Nichter
Approved revision: 539
Merged at revision: 529
Proposed branch: lp://staging/~percona-toolkit-dev/percona-toolkit/enable-version-check-by-default
Merge into: lp://staging/percona-toolkit/2.2
Diff against target: 16013 lines (+5700/-6316)
24 files modified
bin/pt-archiver (+263/-301)
bin/pt-config-diff (+263/-299)
bin/pt-deadlock-logger (+263/-300)
bin/pt-diskstats (+265/-299)
bin/pt-duplicate-key-checker (+264/-300)
bin/pt-find (+264/-301)
bin/pt-fk-error-logger (+263/-300)
bin/pt-heartbeat (+264/-301)
bin/pt-index-usage (+263/-300)
bin/pt-kill (+263/-300)
bin/pt-online-schema-change (+269/-302)
bin/pt-query-advisor (+263/-300)
bin/pt-query-digest (+263/-300)
bin/pt-slave-delay (+270/-303)
bin/pt-slave-restart (+266/-301)
bin/pt-table-checksum (+263/-300)
bin/pt-table-sync (+276/-314)
bin/pt-upgrade (+269/-302)
bin/pt-variable-advisor (+263/-300)
lib/Percona/Toolkit.pm (+1/-1)
lib/VersionCheck.pm (+303/-308)
t/lib/VersionCheck.t (+161/-169)
t/pt-archiver/version_check.t (+97/-47)
t/pt-query-digest/version_check.t (+101/-68)
To merge this branch: bzr merge lp://staging/~percona-toolkit-dev/percona-toolkit/enable-version-check-by-default
Reviewer Review Type Date Requested Status
Daniel Nichter Approve
Brian Fraser (community) Approve
Review via email: mp+148520@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Brian Fraser (fraserbn) :
review: Approve
533. By Brian Fraser

VersionCheck: Skip running if called from our bzr repo

534. By Daniel Nichter

Simplify checking for .bzr/ to auto-disable --version-check in dev and test envs. Update t/pt-archiver/version_check.t. Need to update all other tools...

535. By Daniel Nichter

Test that --version-check works/is enabled by default.

536. By Daniel Nichter

Update VersionCheck in all tools.

537. By Daniel Nichter

Update t/pt-query-digest/version_check.t.

538. By Daniel Nichter

Add force => ->got('version-check') to tools.

539. By Daniel Nichter

Check for ../../.bzr for when a tool is ran as a module in a test.

Revision history for this message
Daniel Nichter (daniel-nichter) wrote :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches