Percona XtraDB Cluster moved to https://jira.percona.com/projects/PXC

Merge lp://staging/~percona-core/percona-xtradb-cluster/bug-1402166 into lp://staging/percona-xtradb-cluster

  1. bug-1402166
  2. Merge into 5.6
Proposed by Raghavendra D Prabhu
Status: Work in progress
Proposed branch: lp://staging/~percona-core/percona-xtradb-cluster/bug-1402166
Merge into: lp://staging/percona-xtradb-cluster
Diff against target: 19 lines (+5/-2)
1 file modified
sql/wsrep_sst.cc (+5/-2)
To merge this branch: bzr merge lp://staging/~percona-core/percona-xtradb-cluster/bug-1402166
Reviewer Review Type Date Requested Status
Alexey Kopytov (community) Needs Fixing
Review via email: mp+245518@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Alexey Kopytov (akopytov) wrote :

Shouldn't the code be rewritten as follows:

    if (!tmp || proc.error())
    {
      WSREP_ERROR("Failed to read uuid:seqno from joiner script.");
      if (proc.error())
        err = proc.error();
    }
    else
    {
      err= sst_scan_uuid_seqno (out, &ret_uuid, &ret_seqno);
    }

review: Needs Information
Reply
Revision history for this message
Raghavendra D Prabhu (raghavendra-prabhu) wrote :

Fixed.

Reply
Revision history for this message
Alexey Kopytov (akopytov) wrote :

1. if tmp == NULL, but proc.error() returns 0, you will overwrite 'err' with 0. Which is wrong.
2. the MySQL coding stile is 'var= val' (note the space after var)
3. please use my_strerror() instead of strerror().

review: Needs Fixing
Reply
Revision history for this message
Raghavendra D Prabhu (raghavendra-prabhu) wrote :

This will be resubmitted with fixes for issue mentioned above, as a separate pull request. (which I will mention here).

Reply

Unmerged revisions

947. By Raghavendra D Prabhu

Refactored the code for more clarity

946. By Raghavendra D Prabhu

Bug#1402166 Fix typo

945. By Raghavendra D Prabhu

Bug#1402166 Check for proc.error() in wsrep_joiner_thread in case the SST script aborts

944. By Alexey Kopytov

Merged lp:~akopytov/percona-xtradb-cluster/bug1382797-5.6.

943. By Raghavendra D Prabhu

Fix the syntax

942. By Raghavendra D Prabhu

Update for backup locks

941. By Raghavendra D Prabhu

Update documentation

940. By Raghavendra D Prabhu

Bug#1396757 Exit early in case mysqld was killed prematurely

939. By Hrvoje Matijakovic

Merged lp:~hrvojem/percona-xtradb-cluster/rn-5.6.21-25.8

938. By Raghavendra D Prabhu

Bump the PERCONA_INNODB_VERSION version

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: