OpenERP Community Backports (Addons)

Merge lp://staging/~pedro.baeza/ocb-addons/7.0-bug-1173102 into lp://staging/ocb-addons

7.0-bug-1173102
Merge into 7.0

Proposed by Pedro Manuel Baeza on 2014-02-12

Status:

Rejected

Rejected by:

Pedro Manuel Baeza on 2014-10-08

Proposed branch:

lp://staging/~pedro.baeza/ocb-addons/7.0-bug-1173102

Merge into:

lp://staging/ocb-addons

Diff against target:

13 lines (+1/-2)

1 file modified

account/account.py (+1/-2)

To merge this branch:

bzr merge lp://staging/~pedro.baeza/ocb-addons/7.0-bug-1173102

Undecided

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Holger Brunn (Therp)	code review	2014-02-12	Needs Information on 2014-02-24
Review via email: mp+205911@code.staging.launchpad.net

Description of the change

[FIX] account: Problem rounding taxes when taxes are included in price.

See lp:1173102 for more details.

Revision history for this message

Holger Brunn (Therp) (hbrunn) wrote on 2014-02-24:

This looks to me like someone calls _compute with the wrong precision. I think http://bazaar.launchpad.net/~ocb/ocb-addons/7.0/view/head:/account/account.py#L2189 is the culprit. Shouldn't we rather fix it there instead of ignoring the precision we get passed in _compute?

review: Needs Information (code review)

Revision history for this message

Pedro Manuel Baeza (pedro.baeza) wrote on 2014-02-24:

I have only copied the solution provided by OpenERP S. A. on trunk, testing that it's working on v7, but without checking the source of the problem. Do you think it can be more generic patching what you say?

Regards.

Revision history for this message

Holger Brunn (Therp) (hbrunn) wrote on 2014-03-03:

I do think changing it where I wrote is the better fix, as it seems quite arbitrary to me to increase rounding precision there

Revision history for this message

Pedro Manuel Baeza (pedro.baeza) wrote on 2014-10-08:

It's solved on upstream.