OpenERP Community Backports (Addons)

Merge lp://staging/~pedro.baeza/ocb-addons/6.1-bug-1253701 into lp://staging/ocb-addons/6.1

  1. 6.1-bug-1253701
  2. Merge into 6.1
Proposed by Pedro Manuel Baeza
Status: Merged
Merged at revision: 6821
Proposed branch: lp://staging/~pedro.baeza/ocb-addons/6.1-bug-1253701
Merge into: lp://staging/ocb-addons/6.1
Diff against target: 12 lines (+1/-1)
1 file modified
mrp/security/mrp_security.xml (+1/-1)
To merge this branch: bzr merge lp://staging/~pedro.baeza/ocb-addons/6.1-bug-1253701
Reviewer Review Type Date Requested Status
Holger Brunn (Therp) code review Approve
Stefan Rijnhart (Opener) Approve
Omar (Pexego) Approve
Raphaël Valyi - http://www.akretion.com Approve
Review via email: mp+196171@code.staging.launchpad.net

Description of the change

Fix for the bug 1253701. Details on the bug.

To post a comment you must log in.
Revision history for this message
Raphaël Valyi - http://www.akretion.com (rvalyi) wrote :

LGTM

review: Approve
Revision history for this message
Omar (Pexego) (omar7r) wrote :

LGTM

Revision history for this message
Omar (Pexego) (omar7r) :
review: Approve
Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

Same as 7.0 version here: https://code.launchpad.net/~pedro.baeza/ocb-addons/7.0-bug-1253701/+merge/196170

review: Approve
Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

Please anyone proceed with the merge then.

Regards.

Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

Hi Pedro,

I know three approvals warrant a merge, but I consider this a fast tracking arrangement in case of an emergency. As this particular proposal does not count as one IMHO, I did not immediately merge after giving the third approval as it seems like a good idea to give other people the opportunity to comment for a couple of more days.

I hope you can understand.
Stefan.

Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

OK, don't worry, I understand perfectly.

Regards.

Revision history for this message
Holger Brunn (Therp) (hbrunn) :
review: Approve (code review)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches