Account - Financial Report

Merge lp://staging/~pedro.baeza/account-financial-report/6.1-balance-reporting into lp://staging/~account-report-core-editor/account-financial-report/6.1

6.1-balance-reporting
Merge into 6.1

Proposed by Pedro Manuel Baeza on 2013-08-30

Status:	Superseded
Proposed branch:	lp://staging/~pedro.baeza/account-financial-report/6.1-balance-reporting
Merge into:	lp://staging/~account-report-core-editor/account-financial-report/6.1
Diff against target:	6018 lines (+5901/-0) 22 files modified account_balance_reporting/__init__.py (+34/-0) account_balance_reporting/__openerp__.py (+70/-0) account_balance_reporting/account_balance_reporting.py (+439/-0) account_balance_reporting/account_balance_reporting_reports.xml (+52/-0) account_balance_reporting/account_balance_reporting_template.py (+212/-0) account_balance_reporting/account_balance_reporting_template_view.xml (+170/-0) account_balance_reporting/account_balance_reporting_view.xml (+200/-0) account_balance_reporting/account_balance_reporting_wizard.xml (+61/-0) account_balance_reporting/account_balance_reporting_workflow.xml (+94/-0) account_balance_reporting/i18n/account_balance_reporting.pot (+538/-0) account_balance_reporting/i18n/ca.po (+607/-0) account_balance_reporting/i18n/es.po (+610/-0) account_balance_reporting/i18n/gl.po (+605/-0) account_balance_reporting/i18n/pl.po (+558/-0) account_balance_reporting/i18n/pt.po (+598/-0) account_balance_reporting/i18n/sv.po (+548/-0) account_balance_reporting/report/__init__.py (+27/-0) account_balance_reporting/report/generic_non_zero_report.rml (+175/-0) account_balance_reporting/report/generic_report.rml (+173/-0) account_balance_reporting/security/ir.model.access.csv (+5/-0) account_balance_reporting/wizard/__init__.py (+30/-0) account_balance_reporting/wizard/wizard_print.py (+95/-0)
To merge this branch:	bzr merge lp://staging/~pedro.baeza/account-financial-report/6.1-balance-reporting
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Frederic Clementi - Camptocamp			Needs Information on 2013-11-11
Maxime Chambreuil (http://www.savoirfairelinux.com)	code review		Needs Fixing on 2013-11-10
Nhomar - Vauxoo		2013-08-30	Pending
Review via email: mp+183114@code.staging.launchpad.net

This proposal has been superseded by a proposal from 2014-01-10.

Description of the change

[ADD] account_balance_reporting:

Module for making custom financial reports using formulas to aggregate balance of the accounts and with custom styles to present them.

It is used by Spanish localization to generate legal fiscal reports.

Revision history for this message

Maxime Chambreuil (http://www.savoirfairelinux.com) (max3903) wrote on 2013-11-10:

Hello Pedro,

Please fix PEP8 issues given by flake8 and consider translating the spanish comments in the code (l257).

Otherwise LGTM.

Thanks!

review: Needs Fixing (code review)

Revision history for this message

Frederic Clementi - Camptocamp (frederic-clementi) wrote on 2013-11-11:

Hello,

I cannot print the report, I get the folowing error...

Traceback (most recent call last):
  File "/home/vrenaville/tmpinstance/61Uptodate/src/server/openerp/service/web_services.py", line 727, in go
    (result, format) = obj.create(cr, uid, ids, datas, context)
  File "/home/vrenaville/tmpinstance/61Uptodate/src/server/openerp/report/report_sxw.py", line 440, in create
    fnct_ret = fnct(cr, uid, ids, data, report_xml, context)
  File "/home/vrenaville/tmpinstance/61Uptodate/src/server/openerp/report/report_sxw.py", line 509, in create_source_pdf
    return self.create_single_pdf(cr, uid, ids, data, report_xml, context)
  File "/home/vrenaville/tmpinstance/61Uptodate/src/server/openerp/report/report_sxw.py", line 531, in create_single_pdf
    pdf = create_doc(etree.tostring(processed_rml),rml_parser.localcontext,logo,title.encode('utf8'))
  File "/home/vrenaville/tmpinstance/61Uptodate/src/server/openerp/report/interface.py", line 207, in create_pdf
    obj.render()
  File "/home/vrenaville/tmpinstance/61Uptodate/src/server/openerp/report/render/render.py", line 59, in render
    self._result = self._render()
  File "/home/vrenaville/tmpinstance/61Uptodate/src/server/openerp/report/render/rml.py", line 41, in _render
    return rml2pdf.parseNode(self.rml, self.localcontext, images=self.bin_datas, path=self.path,title=self.title)
  File "/home/vrenaville/tmpinstance/61Uptodate/src/server/openerp/report/render/rml2pdf/trml2pdf.py", line 1007, in parseNode
    r.render(fp)
  File "/home/vrenaville/tmpinstance/61Uptodate/src/server/openerp/report/render/rml2pdf/trml2pdf.py", line 314, in render
    pt_obj.render(el)
  File "/home/vrenaville/tmpinstance/61Uptodate/src/server/openerp/report/render/rml2pdf/trml2pdf.py", line 983, in render
    fis += r.render(node_story)
  File "/home/vrenaville/tmpinstance/61Uptodate/src/server/openerp/report/render/rml2pdf/trml2pdf.py", line 877, in render
    return process_story(node_story)
  File "/home/vrenaville/tmpinstance/61Uptodate/src/server/openerp/report/render/rml2pdf/trml2pdf.py", line 870, in process_story
    flow = self._flowable(node)
  File "/home/vrenaville/tmpinstance/61Uptodate/src/server/openerp/report/render/rml2pdf/trml2pdf.py", line 793, in _flowable
    return self._table(node)
  File "/home/vrenaville/tmpinstance/61Uptodate/src/server/openerp/report/render/rml2pdf/trml2pdf.py", line 697, in _table
    assert length == len(node.get('colWidths').split(','))
AssertionError

I set a very basic template with just 1 as value in fy 1. Balance mode Debit-credit...and print the report for the fy 2013 (no fy 2)

Any idea ?

Frederic

Hello,

I cannot print the report, I get the folowing error...

Traceback (most recent call last):
  File "/home/vrenaville/tmpinstance/61Uptodate/src/server/openerp/service/web_services.py", line 727, in go
    (result, format) = obj.create(cr, uid, ids, datas, context)
  File "/home/vrenaville/tmpinstance/61Uptodate/src/server/openerp/report/report_sxw.py", line 440, in create
    fnct_ret = fnct(cr, uid, ids, data, report_xml, context)
  File "/home/vrenaville/tmpinstance/61Uptodate/src/server/openerp/report/report_sxw.py", line 509, in create_source_pdf
    return self.create_single_pdf(cr, uid, ids, data, report_xml, context)
  File "/home/vrenaville/tmpinstance/61Uptodate/src/server/openerp/report/report_sxw.py", line 531, in create_single_pdf
    pdf = create_doc(etree.tostring(processed_rml),rml_parser.localcontext,logo,title.encode('utf8'))
  File "/home/vrenaville/tmpinstance/61Uptodate/src/server/openerp/report/interface.py", line 207, in create_pdf
    obj.render()
  File "/home/vrenaville/tmpinstance/61Uptodate/src/server/openerp/report/render/render.py", line 59, in render
    self._result = self._render()
  File "/home/vrenaville/tmpinstance/61Uptodate/src/server/openerp/report/render/rml.py", line 41, in _render
    return rml2pdf.parseNode(self.rml, self.localcontext, images=self.bin_datas, path=self.path,title=self.title)
  File "/home/vrenaville/tmpinstance/61Uptodate/src/server/openerp/report/render/rml2pdf/trml2pdf.py", line 1007, in parseNode
    r.render(fp)
  File "/home/vrenaville/tmpinstance/61Uptodate/src/server/openerp/report/render/rml2pdf/trml2pdf.py", line 314, in render
    pt_obj.render(el)
  File "/home/vrenaville/tmpinstance/61Uptodate/src/server/openerp/report/render/rml2pdf/trml2pdf.py", line 983, in render
    fis += r.render(node_story)
  File "/home/vrenaville/tmpinstance/61Uptodate/src/server/openerp/report/render/rml2pdf/trml2pdf.py", line 877, in render
    return process_story(node_story)
  File "/home/vrenaville/tmpinstance/61Uptodate/src/server/openerp/report/render/rml2pdf/trml2pdf.py", line 870, in process_story
    flow = self._flowable(node)
  File "/home/vrenaville/tmpinstance/61Uptodate/src/server/openerp/report/render/rml2pdf/trml2pdf.py", line 793, in _flowable
    return  self._table(node)
  File "/home/vrenaville/tmpinstance/61Uptodate/src/server/openerp/report/render/rml2pdf/trml2pdf.py", line 697, in _table
    assert length == len(node.get('colWidths').split(','))
AssertionError

I set a very basic template with just 1 as value in fy 1. Balance mode Debit-credit...and print the report for the fy 2013 (no fy 2)

Any idea ?

Frederic

review: Needs Information

lp://staging/~pedro.baeza/account-financial-report/6.1-balance-reporting updated on 2014-01-10

28. By Pedro Manuel Baeza on 2014-01-10: [IMP] Some improvements on report engine.

Revision history for this message

Pedro Manuel Baeza (pedro.baeza) wrote on 2014-01-17:

Hi, I have made some improvements in the code. Please try again to see if all is correct.

Regards.

Unmerged revisions

28. By Pedro Manuel Baeza on 2014-01-10: [IMP] Some improvements on report engine.
27. By Pedro Manuel Baeza on 2013-08-30: [FIX] account_balance_reporting: Some code refactoring.
26. By Pedro Manuel Baeza on 2013-07-11: [ADD] account_financial_reporting: Module for making financial reports. Used in spanish localization.