Merge lp://staging/~peat-new/camera-app/sort-video-resolutions-list into lp://staging/camera-app/staging
| Status: | Merged |
|---|---|
| Approved by: | Florian Boucault |
| Approved revision: | 697 |
| Merge reported by: | Florian Boucault |
| Merged at revision: | not available |
| Proposed branch: | lp://staging/~peat-new/camera-app/sort-video-resolutions-list |
| Merge into: | lp://staging/camera-app/staging |
| Diff against target: |
15 lines (+5/-0) 1 file modified
ViewFinderOverlay.qml (+5/-0) |
| To merge this branch: | bzr merge lp://staging/~peat-new/camera-app/sort-video-resolutions-list |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| system-apps-ci-bot | continuous-integration | Needs Fixing | |
| Florian Boucault (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Sort supported video resolutions list before using it.
Originally, the code assume that the list is in ascending order. But as
some device (e.g. LG L90 Dual) send this list in descending order, and
actually we probably can't rely on it's order anyway, I decided to sort
the list before using it.
This fixes 2 issues:
1.) video resolution ordering in UI being inconsistent.
2.) when a device send this list in descending order, and unsupported
resolution is currently selected, it'll select lowest resolution,
which is sometimes actually too low for encoder. This cause recording
to fail.
Description of the change
Sort supported video resolutions list before using it.
Originally, the code assume that the list is in ascending order. But as
some device (e.g. LG L90 Dual) send this list in descending order, and
actually we probably can't rely on it's order anyway, I decided to sort
the list before using it.
This fixes 2 issues:
1.) video resolution ordering in UI being inconsistent.
2.) when a device send this list in descending order, and unsupported
resolution is currently selected, it'll select lowest resolution,
which is sometimes actually too low for encoder. This cause recording
to fail.
| system-apps-ci-bot (system-apps-ci-bot) wrote | # |
Thanks!