Akiban Persistit

Merge lp://staging/~pbeaman/akiban-persistit/fix_1006576_long_record_pruning into lp://staging/akiban-persistit

  1. fix_1006576_long_record_pruning
  2. Merge into trunk
Proposed by Peter Beaman
Status: Merged
Merged at revision: 314
Proposed branch: lp://staging/~pbeaman/akiban-persistit/fix_1006576_long_record_pruning
Merge into: lp://staging/akiban-persistit
Diff against target: 118 lines (+42/-10)
3 files modified
src/main/java/com/persistit/Buffer.java (+1/-0)
src/main/java/com/persistit/Value.java (+20/-10)
src/test/java/com/persistit/MVCCPruneBufferTest.java (+21/-0)
To merge this branch: bzr merge lp://staging/~pbeaman/akiban-persistit/fix_1006576_long_record_pruning
Reviewer Review Type Date Requested Status
Akiban Build User Needs Fixing
Nathan Williams Needs Information
Review via email: mp+108091@code.staging.launchpad.net

Description of the change

Fix a critical bug that was added with lp:~pbeaman/akiban-persistit/fix_945244_incomplete_pruning.

New code added with that branch failed to restore a Value to normal, non-long-record-mode after using it. When that value is used again, it is in an incorrect state.

This branch fixes the specific problem and adds a test to cover it.

Longer term the handling of "long record mode" in the Value object is murky at best and will be cleaned up when we refactor the Exchange class.

To post a comment you must log in.
Revision history for this message
Nathan Williams (nwilliams) wrote :

Ack, nasty one.

I think this is right. I said that last time, but I've believed it both times!

About the test:
Do we want the pollInterval to be -1 instead of MAX? If correct as-is, feel free to Approve.

review: Needs Information
Revision history for this message
Peter Beaman (pbeaman) wrote :

Yes, -1 is correct. Confusion was caused by my earlier mistake when I set some of these to MAX. I'll press the big-A button.

Revision history for this message
Akiban Build User (build-akiban) wrote :

There were 2 failures during build/test:

* job server-mt failed at build number 1747: http://172.16.20.104:8080/job/server-mt/1747/

* view must-pass failed: server-mt is red

review: Needs Fixing
Revision history for this message
Nathan Williams (nwilliams) wrote :

All the way through and then network hiccup on server-mt.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches