Merge lp://staging/~paulliu/unity8/reboot into lp://staging/unity8
- reboot
- Merge into trunk
Status: | Merged | ||||||||
---|---|---|---|---|---|---|---|---|---|
Approved by: | Michael Zanetti | ||||||||
Approved revision: | 858 | ||||||||
Merged at revision: | 1050 | ||||||||
Proposed branch: | lp://staging/~paulliu/unity8/reboot | ||||||||
Merge into: | lp://staging/unity8 | ||||||||
Diff against target: |
364 lines (+283/-6) 3 files modified
plugins/Unity/Session/dbusunitysessionservice.cpp (+33/-0) plugins/Unity/Session/dbusunitysessionservice.h (+61/-4) qml/Shell.qml (+189/-2) |
||||||||
To merge this branch: | bzr merge lp://staging/~paulliu/unity8/reboot | ||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
PS Jenkins bot (community) | continuous-integration | Needs Fixing | |
Michael Zanetti (community) | Approve | ||
Michał Sawicz | Pending | ||
Review via email: mp+221159@code.staging.launchpad.net |
Commit message
Add reboot/shutdown
Description of the change
* Are there any related MPs required for this MP to build/function as expected?
No.
* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes.
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A
* If you changed the UI, has there been a design review?
No. We need to discuss this in Malta
PS Jenkins bot (ps-jenkins) wrote : | # |
- 851. By Ying-Chun Liu
-
merged trunk
* debian/control:
list qtdeclarative5-ubuntu- ui-toolkit- plugin- gles as an alternative
choice, since provides are not versionned, should restore installability
on amd64 and i386
[ Michał Sawicz ]
* Adapt to suru theme.
[ Michael Terry ]
* Fix path in launcher mock after moving our mock icons, to avoid a
lot of "icon not found" warnings during qmluitests.
* Fix the testMultiGreeter qmluitest. Incoming method variables are
apparently read-only in Qt5.3. (LP: #1332488)
[ CI bot ]
* Resync trunk
[ Michał Sawicz ]
* Adapt scope mock to new api and quiet unused variable warnings.
* Fix dynamic overlay height. (LP: #1334879)
* Don't center items in CardVerticalJournal, kind of beats the
purpose... Also don't bind unnecessarily.
[ Ying-Chun Liu ]
* Fix LP:1330957 Fix some failed test cases. (LP: #1330957)
[ Albert Astals ]
* Don't seem to need this waitForRendering And makes test fail in 5.3
[ Alberto Aguirre ]
* Update Powerd plugin and Shell.qml to accommodate changes in the
display power state notification.
[ Ying-Chun Liu ]
* Add logout support. Reviewed by: Daniel d'Andrada (LP: #1302213)
[ Michał Sawicz ]
* Make so that fixedArtShapeSize actually fixes artShapeSize.
[ Albert Astals ]
* Add VerticalJournal integration to Dash/scopes/QML (LP: #1326467)
* Make so that fixedArtShapeSize actually fixes artShapeSize.
[ Mirco Müller ]
* Added the frontend-part of sound-hint support for notifications with
updated QML-tests.
* New rebuild forced
[ Albert Astals ]
* Departments support (LP: #1320847)
[ Pawel Stolowski ]
* Extend the hack for click scope categories with the upcoming 'store'
category: single-tap on results from the 'store' category should
activate them, instead of requesting a preview. (LP: #1326292)
[ Albert Astals ]
* Drop the " Preview" suffix from Preview title As requested in
https://bugs.launchpad .net/unity8/ +bug/1316671 (LP: #1316671)
[ Michael Terry ]
* Revert split greeter for now. We will bring it back as an option
for Desktop, but use a big hammer revert right now to get Touch back
in shape.
[ CI bot ]
* Fix build problems. Reviewed by: Michael Terry (LP: #1328850)
[ Michał Sawicz ]
* Make lockscreen buttons translatable.
[ Albert Astals ]
* Correctly mark these functions as overrides
* Remove connections to non existant signal
* Better test name
* Improvements for headerless categories LVPWH: No section name -> no
header LVPWH: New hasSectionHeader context property for delegates
GSV: Add topMargin if no hasSectionHeader (LP: #1326415)
* Make tryVerticalJournal, tryHorizontalJournal and tryOrganicGrid
work again
[ Michael Zanetti ]
* Don't crash when we get an invalid app from ApplicationManager (LP:
#1309162)
[ Andrea Cimitan ]
* Workaround for lp1324159 (LP: #1322233, #1324159)
[ CI bot ]
* Resync trunk
[ Florian Boucault ]
* Application startup: changed splash rectangle to be black instead of
white and added a neat little animation. (LP: #1124265)
[ Michael Terry ]
* Bump version so ubuntu-touch-session can reference this one
[ CI bot ]
* Resync trunk
[ Michał Sawicz ]
* Move env setup past session init in greeter wrapper. (LP: #1325882)
* no change rebuild
* drop dbus-x11 dependency of unity8-greeter, it makes us end up with
multiple session dbus daemons which breaks many AP tests in the lab
[ Michael Terry ]
* Bump version for Breaks due to unity8-greeter
* In split mode, determine whether the application identifiers in
AccountsService are click packages or not, so we know the correct
url prefix to use.
* Start logrotate in the greeter's session.
[ Andrea Cimitan ]
* Passes to make tryCommand -qmljsdebugger=port:3768 to enable
debug/profiling test apps
* Fixes carousel shadow
[ Michał Sawicz ]
* Use dpkg-architecture, not gcc, to determine the machine triplet.
[ Ying-Chun Liu ]
* Fix ZoomableImage test failure. (LP: #1317254)
[ Albert Astals ]
* We don't need iconutils in this mock
* Don't reserve space for mascot if no mascot is specified (LP:
#1319343)
* CardHeader is no more, remove stale line in CMakeLists.txt
* GenericScopeViewTest: Wait a bit more Otherwise sometimes we end
getting up the wrong delegate (maybe one that will be garbage
collected?) (LP: #1322279)
* Fix crash in organicgridtest
[ Daniel d'Andrada ]
* Remove Shell's underlay background image as it cannot be seen
anymore Now that the Dash has its own, opaque, background, the
underlay's background image can no longer be seen. So it's just a
waste of resources to have it.
[ Michael Terry ]
* Use the same animation when dismissing a greeter slide from the
launcher as from a normal greeter drag. (LP: #1316513)
[ Michael Zanetti ]
* enhance lockscreen add a retry indication label (e.g. 3 attempts
left). add an additional label (e.g. phone number for multi sim).
add a infoPopup (e.g. to display a warning for last retry). add min
and max limit values. add tests for the above (LP: #1302050)
PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:851
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
Click here to trigger a rebuild:
http://
- 852. By Ying-Chun Liu
-
fix dialog
- 853. By Ying-Chun Liu
-
Merge trunk
[ Nick Dedekind ]
* Added support for TransferMenu
[ Michał Sawicz ]
* Initial code for a payment button widget, to handle purchasing apps
from the click scope.
[ Nick Dedekind ]
* Moved [Message]MenuItemFacotor y from Unity.Indicators plugin to qml
folder.
[ Albert Astals ]
* EasingCurve: Initialize members
* Fix valgrind warning by not emitting reset on model destructor That
won't be supported until Qt 5.4 More info at https://bugreports. qt-
project.org/browse/ QTBUG-39780 Warning was ==16693== Invalid read of
size 8 ==16693== at 0x72B19A0: QQmlContext::isValid( ) const
(qqmlcontext.cpp:231) ==16693== by 0x736C82B:
QQmlDelegateModelPrivate: :emitChanges( ) (qqmldelegatemo del.cpp: 1412)
==16693== by 0x7372AE6: QQmlDelegateModel::_q_ modelReset( )
(qqmldelegatemodel.cpp: 1463) ==16693== by 0x7397224:
QQmlDelegateModel::qt_ static_ metacall( QObject* , QMetaObject::Call,
int, void**) (moc_qqmldelegatemodel_ p.cpp:196) ==16693== by
0x739769E: QQmlDelegateModel::qt_ metacall( QMetaObject: :Call, int,
void**) (moc_qqmldelegatemodel_ p.cpp:292) ==16693== by 0x66379CC:
QMetaObject::activate( QObject* , int, int, void**) (in
/usr/lib/x86_ 64-linux- gnu/libQt5Core. so.5.3. 0) ==16693== by
0x65AEEFD: QAbstractItemModel::endResetMo del() (in /usr/lib/x86_64-
linux-gnu/libQt5Core. so.5.3. 0) ==16693== by 0x23461EFD:
FakeIndicatorsModel: :unload( ) (fakeindicators model.cpp: 53) ==16693==
by 0x23461E13: FakeIndicatorsModel::~ FakeIndicatorsM odel()
(fakeindicatorsmodel. cpp:34) ==16693== by 0x2345C073:
QQmlPrivate::QQmlElement< FakeIndicatorsM odel>:: ~QQmlElement( ) (in
/home/tsdgeos_ work/phablet/ unity8/ investigate_ test_shell_ crash/build
dir/tests/mocks/Unity/ Indicators/ libIndicatorsFa keQml.so) ==16693==
by 0x2345C0A3:
QQmlPrivate::QQmlElement< FakeIndicatorsM odel>:: ~QQmlElement( )
(qqmlprivate.h:106) ==16693== by 0x663636B:
QObjectPrivate::deleteChildr en() (in /usr/lib/ x86_64- linux-
gnu/libQt5Core.so.5. 3.0) ==16693== Address 0x1862d448 is 8 bytes
inside a block of size 16 free'd ==16693== at 0x4C2C2BC: operator
delete(void*) (vg_replace_malloc. c:503) ==16693== by 0x72B21B8:
QQmlContextData::destroy( ) (qqmlcontext. cpp:647) ==16693== by
0x7293458: QQmlPrivate::qdeclarativeel ement_destructo r(QObject* )
(qqmlengine.cpp:612) ==16693== by 0x6C0CADD:
QQmlPrivate::QQmlElement< QQuickItem> ::~QQmlElement( )
(qqmlprivate.h:105) ==16693== by 0x663636B:
QObjectPrivate::deleteChildr en() (in /usr/lib/ x86_64- linux-
gnu/libQt5Core.so.5. 3.0) ==16693== by 0x663F0EB: QObject::~QObject()
(in /usr/lib/x86_64- linux-gnu/ libQt5Core. so.5.3. 0) ==16693== by
0x6BF64B5: QQuickItem::~QQuickItem( ) (qquickitem. cpp:2064) ==16693==
by 0x6C0CAE5: QQmlPrivate::QQmlElement< QQuickItem> ::~QQmlElement( )
(qqmlprivate.h:106) ==16693== by 0x663636B:
QObjectPrivate::deleteChildr en() (in /usr/lib/ x86_64- linux-
gnu/libQt5Core.so.5. 3.0) ==16693== by 0x663F0EB: QObject::~QObject()
(in /usr/lib/x86_64- linux-gnu/ libQt5Core. so.5.3. 0) ==16693== by
0x6BF64B5: QQuickItem::~QQuickItem( ) (qquickitem. cpp:2064) ==16693==
by 0x6C0CAE5: QQmlPrivate::QQmlElement< QQuickItem> ::~QQmlElement( )
(qqmlprivate.h:106) (LP: #1332598)
[ Michael Zanetti ]
* drop launcher item spacing (LP: #1332022)
* change wording in launcher quicklist (LP: #1332035)
[ Alejandro J. Cura ]
* Initial code for a payment button widget, to handle purchasing apps
from the click scope.
[ Rodney Dawes ]
* Initial code for a payment button widget, to handle purchasing apps
from the click scope.
[ Renato Araujo Oliveira Filho ]
* Create IndicatorsLight.qml component used to control indicator led.
A blue led will pulse if the message indicator is blue and screen is
off. - 854. By Ying-Chun Liu
-
Fix FTBFS
PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:854
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
Michael Zanetti (mzanetti) wrote : | # |
I'm not sure if its a good idea to have the exact same interface exported into the shell and on D-Bus. Besides the fact that it looks quite chaotic, it also raises some security concerns here...
Michal, your opinion?
Michał Sawicz (saviq) wrote : | # |
> I'm not sure if its a good idea to have the exact same interface exported into
> the shell and on D-Bus. Besides the fact that it looks quite chaotic, it also
> raises some security concerns here...
While I agree this is not ideal, the whole API here is rather temporary, until we spend the much needed time for analysis on session handling with accordance to fdo, systemd, logind etc. etc.
And applications can't call this API anyway, so it *should* be fine for now.
- 855. By Ying-Chun Liu
-
Add fade-out effect.
- 856. By Ying-Chun Liu
-
Merge trunk
- 857. By Ying-Chun Liu
-
Fix bugs.
PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:857
http://
Executed test runs:
FAILURE: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
Ying-Chun Liu (paulliu) wrote : | # |
The DBus is not used by the phone. It is for the desktop.
The indicators-session will use that DBus interface to ask the unity8 to shutdown.
- 858. By Ying-Chun Liu
-
Merge trunk
[ Michal Hruby ]
* Fix FTBFS when using latest unity-api.
[ Michał Sawicz ]
* Refactor carousel item activation.
* Refactor ScopeItem into GenericScopeView.
* Add initial support for scope customizations.
* Make rating stars in PreviewReviewDisplay.qml non-interactive. (LP:
#1337508)
[ Nick Dedekind ]
* Added active call hint A hint is displayed in the indicator panel
when an call is active on the Telephony Serivce
[ Albert Astals ]
* We need to boostrap height also when we have 1 item ^_^ (LP:
#1337408)
* Add initial support for scope customizations.
* CardCreator: Give a correct implicitHeight if we only have art The
hasSubtitle change is really unrelated and not needed here, just
sneaking it in to not create yet another review. (LP: #1330899)
* Fake Scopes Plugin: Register PreviewModelInterface
[ Michael Zanetti ]
* make the launcher's drag'n'drop indicator more prominent (LP:
#1332042)
* make launcher items live having them non-live is not really required
and reveals an issue in combination with UbuntuShape (LP: #1302761)
* Fade out launcher in place instead of moving it to the left on long
left edge swipes. (LP: #1332096)
* update launcher icon glow as requested by design (LP: #1336725)
* update header in dash to use the new header from the SDK (LP:
#1335491)
* fix testPreview with larger GRID_UNIT_PX values
* clip the corner of pinned icons in the launcher as per new design
* update launcher background according to latest design (LP: #1336314)
* Update Launcher's home button design according to new spec. (LP:
#1329331)
[ CI bot ]
* make launcher items live having them non-live is not really required
and reveals an issue in combination with UbuntuShape (LP: #1302761)
PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:858
http://
Executed test runs:
FAILURE: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:858
http://
Executed test runs:
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
Michael Zanetti (mzanetti) wrote : | # |
> The DBus is not used by the phone. It is for the desktop.
> The indicators-session will use that DBus interface to ask the unity8 to
> shutdown.
Not sure I understand what you're trying to say with this. But anyways, given its temporary I guess we can land as is... It worked fine in my tests...
* Did you perform an exploratory manual test run of the code change and any related functionality?
ya
* Did CI run pass? If not, please explain why.
no. flaky, unrelated tests
Michael Zanetti (mzanetti) wrote : | # |
Oh... just saw the description says to NOT approve this branch yet... What's the status with that?
Ying-Chun Liu (paulliu) wrote : | # |
> Oh... just saw the description says to NOT approve this branch yet... What's
> the status with that?
Sorry. I fix the description.
Thanks.
- 859. By Ying-Chun Liu
-
Merge trunk.
[ Michał Sawicz ]
* Activate all results in click scope by default. (LP: #1341262)
[ Mirco Müller ]
* Added support for utilization of the ComboButton SDK-element for
snap-decision notifications with many actions. - 860. By Ying-Chun Liu
-
Merge trunk.
Ying-Chun Liu (paulliu) wrote : | # |
I just merge trunk and request a jenkins rebuild to see if it fix.
PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:858
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
FAILED: Continuous integration, rev:850 jenkins. qa.ubuntu. com/job/ unity8- ci/3314/ jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- utopic- touch/1539/ console jenkins. qa.ubuntu. com/job/ unity-phablet- qmluitests- utopic/ 318/console jenkins. qa.ubuntu. com/job/ unity8- utopic- amd64-ci/ 408/console jenkins. qa.ubuntu. com/job/ unity8- utopic- armhf-ci/ 408/console jenkins. qa.ubuntu. com/job/ unity8- utopic- i386-ci/ 408/console jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- utopic- armhf/2522/ console
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/unity8- ci/3314/ rebuild
http://