Juju Charms Collection
ntp package

Merge lp://staging/~paulgear/charms/trusty/ntp/sync-canonical-is-charms into lp://staging/charms/trusty/ntp

  1. Trusty Tahr (14.04)
  2. sync-canonical-is-charms
  3. Merge into trunk
Proposed by Paul Gear
Status: Merged
Merged at revision: 25
Proposed branch: lp://staging/~paulgear/charms/trusty/ntp/sync-canonical-is-charms
Merge into: lp://staging/charms/trusty/ntp
Diff against target: 179 lines (+62/-38)
3 files modified
config.yaml (+6/-5)
hooks/ntp_hooks.py (+53/-30)
templates/ntp.conf (+3/-3)
To merge this branch: bzr merge lp://staging/~paulgear/charms/trusty/ntp/sync-canonical-is-charms
Reviewer Review Type Date Requested Status
Stuart Bishop (community) Approve
Review Queue (community) automated testing Needs Fixing
Review via email: mp+276951@code.staging.launchpad.net

Description of the change

This has the following features/fixes:

- The use_iburst and auto_peers config options are now true by default. In environments which perform outbound UDP rate-limiting, it is recommended to change this to false.

- If all Nagios checks are enabled, they are merged into a single check, reducing noise and increasing efficiency.

- Should fix https://bugs.launchpad.net/charms/+source/ntp/+bug/1480564 due to consolidated handling of peers & sources in hook code.

This eliminates the differences in canonical-is-charms and will allow us to use the trunk charm.

To post a comment you must log in.
Revision history for this message
Review Queue (review-queue) wrote :

This item has failed automated testing! Results available here http://juju-ci.vapour.ws:8080/job/charm-bundle-test-lxc/1392/

review: Needs Fixing (automated testing)
lp://staging/~paulgear/charms/trusty/ntp/sync-canonical-is-charms updated
29. By Paul Gear

Run of make lint with vanilla flake8 config

Revision history for this message
Review Queue (review-queue) wrote :

This item has failed automated testing! Results available here http://juju-ci.vapour.ws:8080/job/charm-bundle-test-lxc/1448/

review: Needs Fixing (automated testing)
Revision history for this message
Review Queue (review-queue) wrote :

This item has failed automated testing! Results available here http://juju-ci.vapour.ws:8080/job/charm-bundle-test-aws/1433/

review: Needs Fixing (automated testing)
Revision history for this message
Stuart Bishop (stub) wrote :

This all looks good and makes sense.

The test suite is all green at http://reports.vapour.ws/all-bundle-and-charm-results/ntp

Will land.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: