Juju Charms Collection
gunicorn package

Merge lp://staging/~patrick-hetu/charms/precise/gunicorn/fix_quotes into lp://staging/~charmers/charms/precise/gunicorn/trunk

  1. Precise Pangolin (12.04)
  2. fix_quotes
  3. Merge into trunk
Proposed by Patrick Hetu
Status: Rejected
Rejected by: Matt Bruzek
Proposed branch: lp://staging/~patrick-hetu/charms/precise/gunicorn/fix_quotes
Merge into: lp://staging/~charmers/charms/precise/gunicorn/trunk
Diff against target: 12 lines (+1/-1)
1 file modified
hooks/hooks.py (+1/-1)
To merge this branch: bzr merge lp://staging/~patrick-hetu/charms/precise/gunicorn/fix_quotes
Reviewer Review Type Date Requested Status
Matt Bruzek (community) Needs Fixing
Review via email: mp+216358@code.staging.launchpad.net

Description of the change

Fix a quoting problem that prevent gunicorn from working with the latest django charm.

To post a comment you must log in.
Revision history for this message
Matt Bruzek (mbruzek) wrote :

This change is superceded by https://code.launchpad.net/~bloodearnest/charms/precise/gunicorn/upgrade-path/+merge/213236

review: Needs Fixing
Revision history for this message
Matt Bruzek (mbruzek) wrote :

Hello Patrick,

Thanks for your submission, but Simon Davy (bloodearnest) fixed this problem in a different merge propsoal that was merged today. I was able to verify that gunicorn worked with the current python-django charm.

I rejected this merge proposal because the problem was already addressed by a different merge propsoal. Please contact me or reopen the merge proposal if you have anything else to add.

Thank you,

  - Matt Bruzek

Revision history for this message
Simon Davy (bloodearnest) wrote :

Patrick, FWIW, my fix was

    if str(wsgi_config['wsgi_workers']) == '0':

as it could be an int (when set via config) and a string (when set via relation), so I forced to string, to preserve the config type of int.

Thanks.

Revision history for this message
Patrick Hetu (patrick-hetu) wrote :

Nice, thanks a lot!

Unmerged revisions

30. By Patrick Hetu

typo

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: