Juju Charms Collection
python-moinmoin package

Code review comment for lp://staging/~patrick-hetu/charms/oneiric/python-moinmoin/trunk

  1. Oneiric (11.10)
  2. trunk
  3. Merge into trunk
Revision history for this message
Clint Byrum (clint-fewbar) wrote :

Hi Patrick!

The boolean field requires that you use boolean values in metadata.yaml.

I'd recommend against using it until we add a new "format" key and then we'll have 'config-get --test boolean-field-name' so that you can test true/false rather than interpreting the string.

Anyway, your charm won't deploy:

2012-05-23 13:49:52,388 WARNING Charm 'python-moinmoin' has an error: ServiceConfigValueError("Invalid value for xapian_search: 'true'",) Invalid value for xapian_search: 'true'

Please change it back to string, or remove the quotes around "true" and check all usage of the config field to make sure they will operate properly by interpreting it as *json* not 'True' or 'False' literally.

review: Needs Fixing

« Back to merge proposal