Merge lp://staging/~pat-mcgowan/ubuntu-system-settings/other-vibrations into lp://staging/ubuntu-system-settings
Status: | Merged | ||||||||
---|---|---|---|---|---|---|---|---|---|
Approved by: | Jonas G. Drange | ||||||||
Approved revision: | 1702 | ||||||||
Merged at revision: | 1703 | ||||||||
Proposed branch: | lp://staging/~pat-mcgowan/ubuntu-system-settings/other-vibrations | ||||||||
Merge into: | lp://staging/ubuntu-system-settings | ||||||||
Prerequisite: | lp://staging/~fboucault/ubuntu-system-settings/crossbuild_fixes | ||||||||
Diff against target: |
147 lines (+30/-16) 4 files modified
plugins/sound/PageComponent.qml (+6/-0) plugins/sound/sound.cpp (+21/-14) plugins/sound/sound.h (+2/-1) po/extractsettingsinfo (+1/-1) |
||||||||
To merge this branch: | bzr merge lp://staging/~pat-mcgowan/ubuntu-system-settings/other-vibrations | ||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jonas G. Drange (community) | Approve | ||
system-apps-ci-bot | continuous-integration | Needs Fixing | |
Review via email: mp+303682@code.staging.launchpad.net |
This proposal supersedes a proposal from 2016-08-22.
Commit message
* allows uss to be built by crossbuilder
* adds dbus interface to communicate with usensord
* hides ringer slider when there's no modem
Description of the change
This branch has three changes
It fixes the debian files to work with crossbuilder
It adds a dbus interface to communicate with usensord to get and set the other-vibrate property (lp:1433590)
It adds a missing connection for NetworkingStatus and does not show the ringer slider when there is no modem (lp:1614637)
The corresponding usensord support is in https:/
See https:/
LGTM, thanks. Also, let's wait for ci to run before top-approving?