Merge lp://staging/~parthpanchl/ubiquity/fix-1429461 into lp://staging/ubiquity

Proposed by Parth Panchal
Status: Work in progress
Proposed branch: lp://staging/~parthpanchl/ubiquity/fix-1429461
Merge into: lp://staging/ubiquity
Diff against target: 57 lines (+12/-10)
2 files modified
ubiquity/frontend/kde_components/PartMan.py (+6/-2)
ubiquity/plugins/ubi-partman.py (+6/-8)
To merge this branch: bzr merge lp://staging/~parthpanchl/ubiquity/fix-1429461
Reviewer Review Type Date Requested Status
Dimitri John Ledkov (community) Needs Resubmitting
Jonathan Riddell Pending
Review via email: mp+252226@code.staging.launchpad.net

Description of the change

Reimplements `get_current_method` in ubi-partman.py according to its argument `partition` (dict).

To post a comment you must log in.
Revision history for this message
Jonathan Riddell (jr) wrote :

Seems to work nice.

One issue:
select a partition
click Change it opens the dialog
disk format is correct selected (yay)
but Format checkbox is now enabled, I have to select a different disk format before I can tick it

6278. By Parth Panchal

Fixes disabled partition_edit_format_checkbutton

Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

Seems fine. I'll test it here and merge hopefully today.

Revision history for this message
Dimitri John Ledkov (xnox) wrote :

The development of ubiquity has moved to git, still hosted on launchpad. If this merge proposal is still relevant, please resubmit it against the git branches found at https://code.launchpad.net/ubiquity

Sorry for any inconvenience caused.

review: Needs Resubmitting

Unmerged revisions

6278. By Parth Panchal

Fixes disabled partition_edit_format_checkbutton

6277. By Parth Panchal

[r=parthpanchl] manual parition new/change dialog should pre-select filetype (LP: #1429461).

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: