Merge lp://staging/~parnold-x/slingshot/fix-1457597 into lp://staging/~elementary-pantheon/slingshot/trunk

Proposed by Djax
Status: Rejected
Rejected by: Danielle Foré
Proposed branch: lp://staging/~parnold-x/slingshot/fix-1457597
Merge into: lp://staging/~elementary-pantheon/slingshot/trunk
Diff against target: 308 lines (+139/-123)
2 files modified
po/slingshot.pot (+127/-123)
src/Widgets/SearchView.vala (+12/-0)
To merge this branch: bzr merge lp://staging/~parnold-x/slingshot/fix-1457597
Reviewer Review Type Date Requested Status
elementary Pantheon team Pending
Review via email: mp+260997@code.staging.launchpad.net

Commit message

Show switchboard plug .desktop files in a new settings search category

Description of the change

Show switchboard plug .desktop files in a new settings search category.

To post a comment you must log in.
Revision history for this message
Danielle Foré (danrabbit) wrote :

Maybe instead of looking for a prefix, we should be looking for categories. Most notably "X-PANTHEON-Switchboard-Plugs"

Revision history for this message
Djax (parnold-x) wrote :

Also possible. But not all have this category. For example the sound plug .desktop file.

We could also add a switchboard plugin that get's the plugs from the api so we don't must manage all those .desktop files?

Revision history for this message
Danielle Foré (danrabbit) wrote :

Rejecting in favor of the Switchboard API approach https://code.launchpad.net/~parnold-x/slingshot/switchboard-plugin

Unmerged revisions

546. By Djax

Show settings in a new search category

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches