Ubuntu
samba package

Merge ~paride/ubuntu/+source/samba:lp1942195-hirsute into ubuntu/+source/samba:ubuntu/hirsute-devel

Git
lp:~paride/ubuntu/+source/samba
lp1942195-hirsute
Merge into ubuntu/hirsute-devel

Proposed by Paride Legovini on 2021-11-10

Status:

Merged

Merged at revision:

b3e0133179e131c3c529ff4a22f3c024b7b0fec7

Proposed branch:

~paride/ubuntu/+source/samba:lp1942195-hirsute

Merge into:

ubuntu/+source/samba:ubuntu/hirsute-devel

Diff against target:

40 lines (+7/-14)

2 files modified

debian/changelog (+7/-0)
debian/samba.postinst (+0/-14)

Undecided

Fix Released

Link a bug report

Reviewer	Date Requested	Status
Sergio Durigan Junior (community)	2021-11-10	Approve on 2021-11-12
Canonical Server Core Reviewers	2021-11-10	Pending
Review via email: mp+411692@code.staging.launchpad.net

Commit message

Hirsute SRU for LP: #1942195, see the SRU template for more info testing instructions.
Test PPA: Test PPA: https://launchpad.net/~paride/+archive/ubuntu/samba-lp1942195

Autopkgtest:

@@@@@@@@@@@@@@@@@@@@ summary
cifs-share-access SKIP Test requires machine-level isolation but testbed does not provide that
cifs-share-access-uring SKIP Test requires machine-level isolation but testbed does not provide that
python-smoke PASS
smbclient-anonymous-share-list PASS
smbclient-authenticated-share-list PASS
smbclient-share-access PASS
smbclient-share-access-uring PASS

Please review & sponsor. Thanks!

Revision history for this message

Sergio Durigan Junior (sergiodj) wrote on 2021-11-11:

Thanks.

Tested locally; all good.

I have a small request before I proceed: could you squash the two commits at the top of the branch, please? Once you do that, I can sponsor the package right away.

Thanks.

Revision history for this message

Paride Legovini (paride) wrote on 2021-11-11:

Good catch, done. I dropped the latest commit instead of squashing as it contained just a change in the d/changelog timestamp. Apparently I run some dch command twice.

Revision history for this message

Paride Legovini (paride) wrote on 2021-11-11:

Full autopkgtest results:

autopkgtest [11:43:57]: @@@@@@@@@@@@@@@@@@@@ summary
cifs-share-access PASS
cifs-share-access-uring PASS
python-smoke PASS
smbclient-anonymous-share-list PASS
smbclient-authenticated-share-list PASS
smbclient-share-access PASS
smbclient-share-access-uring PASS

Revision history for this message

Paride Legovini (paride) wrote on 2021-11-12:

@Sergio rebased on 2:4.13.14+dfsg-0ubuntu0.21.04.1, up for review again.

Revision history for this message

Paride Legovini (paride) wrote on 2021-11-12:

New autopkgtest results:

autopkgtest [16:25:36]: @@@@@@@@@@@@@@@@@@@@ summary
cifs-share-access PASS
cifs-share-access-uring PASS
python-smoke PASS
smbclient-anonymous-share-list PASS
smbclient-authenticated-share-list PASS
smbclient-share-access PASS
smbclient-share-access-uring PASS

Revision history for this message

Sergio Durigan Junior (sergiodj) wrote on 2021-11-12:

Thanks, Paride.

LGTM. The only minor comment I have is regarding the PPA: it is useful to enable all supported architectures and configuring the build to use the -proposed pocket when building. Not that I'm concerned about arch-specific failures with these SRUs, but it's something I thought I'd bring up for next time :-).

Uploaded:

$ dput samba_4.13.14+dfsg-0ubuntu0.21.04.2_source.changes
Trying to upload package to ubuntu
Checking signature on .changes
gpg: /home/sergio/work/samba/samba_4.13.14+dfsg-0ubuntu0.21.04.2_source.changes: Valid signature from 106DA1C8C3CBBF14
Checking signature on .dsc
gpg: /home/sergio/work/samba/samba_4.13.14+dfsg-0ubuntu0.21.04.2.dsc: Valid signature from 106DA1C8C3CBBF14
Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading samba_4.13.14+dfsg-0ubuntu0.21.04.2.dsc: done.
  Uploading samba_4.13.14+dfsg-0ubuntu0.21.04.2.debian.tar.xz: done.
  Uploading samba_4.13.14+dfsg-0ubuntu0.21.04.2_source.buildinfo: done.
  Uploading samba_4.13.14+dfsg-0ubuntu0.21.04.2_source.changes: done.
Successfully uploaded packages.